[GitHub] [ignite-3] ibessonov commented on a diff in pull request #1899: IGNITE-19179 Make logical topology rejoins idempotent

["ibessonov (via GitHub)" <gi...@apache.org>]

ibessonov commented on code in PR #1899:
URL: https://github.com/apache/ignite-3/pull/1899#discussion_r1159395296


##########
modules/cluster-management/src/main/java/org/apache/ignite/internal/cluster/management/topology/api/LogicalNode.java:
##########
@@ -79,10 +78,9 @@ public Map<String, String> nodeAttributes() {
         return nodeAttributes;
     }
 
-    /** {@inheritDoc} */
-    @Override
-    public String toString() {
-        // TODO: S.toString for inherited classes do not work properly https://issues.apache.org/jira/browse/IGNITE-19183
-        return S.toString(LogicalNode.class, this);
-    }
+    // TODO: S.toString for inherited classes do not work properly https://issues.apache.org/jira/browse/IGNITE-19183
+    //    @Override
+    //    public String toString() {
+    //        return S.toString(LogicalNode.class, this);
+    //    }

Review Comment:
   What was the reason for commenting this code? Maybe you forgot to uncomment it, I don't know



##########
modules/raft/src/main/java/org/apache/ignite/raft/jraft/rpc/ActionRequest.java:
##########
@@ -35,7 +34,6 @@ public interface ActionRequest extends Message {
     /**
      * @return Action's command.
      */
-    @Marshallable

Review Comment:
   Thank you very much! :+1: 



##########
modules/cluster-management/src/main/java/org/apache/ignite/internal/cluster/management/topology/LogicalTopologyImpl.java:
##########
@@ -96,6 +96,10 @@ public void putNode(LogicalNode nodeToPut) {
             // This is an update. First simulate disappearance, then appearance will be fired.
             snapshot = new LogicalTopologySnapshot(snapshot.version() + 1, mapByName.values());
 
+            if (LOG.isInfoEnabled()) {

Review Comment:
   I would like to comment the code above.
   ```
               if (oldNode.id().equals(nodeToPut.id())) {
                   // We already have this node, nothing needs to be changed.
                   return;
               }
   ```
   How is it possible?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org