You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@bahir.apache.org by ankitagr2312 <gi...@git.apache.org> on 2017/10/17 05:31:01 UTC
[GitHub] bahir pull request #53: [BAHIR-141] Added support for passing json cred file...
GitHub user ankitagr2312 opened a pull request:
https://github.com/apache/bahir/pull/53
[BAHIR-141] Added support for passing json cred file as byte array
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ankitagr2312/bahir BAHIR-141
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/bahir/pull/53.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #53
----
commit 5977497c08761f5ed5a6f66f223070b48a7272b1
Author: exadatum-ankit <an...@exadatum.com>
Date: 2017-10-17T05:29:08Z
[BAHIR-141] Added support for passing json cred file as byte array
----
---
[GitHub] bahir issue #53: [BAHIR-141] Added support for passing json cred file as byt...
Posted by ApacheBahir <gi...@git.apache.org>.
Github user ApacheBahir commented on the issue:
https://github.com/apache/bahir/pull/53
Refer to this link for build results (access rights to CI server needed):
http://169.45.79.58:8080/job/bahir_spark_pr_builder/151/
---
[GitHub] bahir issue #53: [BAHIR-141] Added support for passing json cred file as byt...
Posted by lukasz-antoniak <gi...@git.apache.org>.
Github user lukasz-antoniak commented on the issue:
https://github.com/apache/bahir/pull/53
Follow up in PR #82.
---
[GitHub] bahir issue #53: [BAHIR-141] Added support for passing json cred file as byt...
Posted by ApacheBahir <gi...@git.apache.org>.
Github user ApacheBahir commented on the issue:
https://github.com/apache/bahir/pull/53
Can one of the admins verify this patch?
---
[GitHub] bahir issue #53: [BAHIR-141] Added support for passing json cred file as byt...
Posted by lukasz-antoniak <gi...@git.apache.org>.
Github user lukasz-antoniak commented on the issue:
https://github.com/apache/bahir/pull/53
@ankitagr2312: Since the last update is already one year old, do you plan to
work on this JIRA ticket and pull request? If not, do you agree that I take it from here?
1) I think that `ServiceAccountCredentials` could be divided into two separate implementations of `SparkGPCCredentials` interface. First implementation `JsonConfigCredentials` would accept either path to JSON file or binary content. Second implementation `EmailPrivateKeyCredentials` would require passing email address and path to P12 key or binary content of the key.
2) Can you revert to original formatting of lines that you did not mean to modify?
3) Update the _README.md_ to include new feature? Undocumented feature is not a feature :).
---
[GitHub] bahir issue #53: [BAHIR-141] Added support for passing json cred file as byt...
Posted by ApacheBahir <gi...@git.apache.org>.
Github user ApacheBahir commented on the issue:
https://github.com/apache/bahir/pull/53
:red_circle: Build failed, see build log for details
---
[GitHub] bahir issue #53: [BAHIR-141] Added support for passing json cred file as byt...
Posted by surajnayak <gi...@git.apache.org>.
Github user surajnayak commented on the issue:
https://github.com/apache/bahir/pull/53
@ankitagr2312, I hope you need to add formatting rules/template to the IDE. Any reason to change the spark.close to spark.stop in the test suits?
---
[GitHub] bahir issue #53: [BAHIR-141] Added support for passing json cred file as byt...
Posted by ankitagr2312 <gi...@git.apache.org>.
Github user ankitagr2312 commented on the issue:
https://github.com/apache/bahir/pull/53
Yup... will do that and send a pull request again.
On Tue, Oct 17, 2017 at 1:44 AM, tedyu <no...@github.com> wrote:
> Is it possible to add a test ?
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/bahir/pull/53#issuecomment-337161707>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/AO_KsXA59F0ZrMfYwcKRVhYA2hm2SVi-ks5stGkEgaJpZM4P7mdd>
> .
>
---
[GitHub] bahir issue #53: [BAHIR-141] Added support for passing json cred file as byt...
Posted by tedyu <gi...@git.apache.org>.
Github user tedyu commented on the issue:
https://github.com/apache/bahir/pull/53
Is it possible to add a test ?
---