[GitHub] [iceberg] grbinho commented on pull request #6223: Use provided glue catalog id in defaultWarehouseLocation

[GitBox <gi...@apache.org>]

grbinho commented on PR #6223:
URL: https://github.com/apache/iceberg/pull/6223#issuecomment-1321089167

   > LGTM ! Thanks @grbinho .
   > 
   > You can add a UT for now it by mocking GetDatabase request and making sure catalogId passed in it. can ref this [existing test](https://github.com/apache/iceberg/blob/master/aws/src/test/java/org/apache/iceberg/aws/glue/TestGlueCatalog.java#L136)
   > 
   > cc @jackye1995
   
   I added a unit test with `AwsProperties.GLUE_CATALOG_ID` property set in `AwsProperties`.   
   This seemed like the way to go with this one since test is supposed to validate that property is actually used in the method.  
   I'm not that experienced with Java and Mockito, so feedback on the correct way to do this is welcome!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org