You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "nandorKollar (via GitHub)" <gi...@apache.org> on 2026/02/19 23:07:12 UTC
[PR] Remove code duplication in PolicyCatalog [polaris]
nandorKollar opened a new pull request, #3846:
URL: https://github.com/apache/polaris/pull/3846
<!--
๐ Describe what changes you're proposing, especially breaking or user-facing changes.
๐ See https://github.com/apache/polaris/blob/main/CONTRIBUTING.md for more.
-->
This PR removes a duplicated code block from PolicyCatalog.
## Checklist
- [ ] ๐ก๏ธ Don't disclose security issues! (contact security@apache.org)
- [ ] ๐ Clearly explained why the changes are needed, or linked related issues: Fixes #
- [ ] ๐งช Added/updated tests with good coverage, or manually tested (and explained how)
- [ ] ๐ก Added comments for complex logic
- [ ] ๐งพ Updated `CHANGELOG.md` (if needed)
- [ ] ๐ Updated documentation in `site/content/in-dev/unreleased` (if needed)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove code duplication in PolicyCatalog [polaris]
Posted by "nandorKollar (via GitHub)" <gi...@apache.org>.
nandorKollar closed pull request #3846: Remove code duplication in PolicyCatalog
URL: https://github.com/apache/polaris/pull/3846
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove code duplication in PolicyCatalog [polaris]
Posted by "nandorKollar (via GitHub)" <gi...@apache.org>.
nandorKollar commented on PR #3846:
URL: https://github.com/apache/polaris/pull/3846#issuecomment-3932284195
@dimas-b CI doesn't look happy, not sure why. Do you maybe have an idea?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove code duplication in PolicyCatalog [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on PR #3846:
URL: https://github.com/apache/polaris/pull/3846#issuecomment-3948337585
CI failure:
```
Execution failed for task ':polaris-runtime-service:compileJava'.
> Compilation failed; see the compiler output below.
/home/runner/work/polaris/polaris/runtime/service/src/main/java/org/apache/polaris/service/catalog/policy/PolicyCatalog.java:287: error: cannot find symbol
@Nonnull PolicyAttachmentTarget target,
^
symbol: class Nonnull
location: class PolicyCatalog
2 errors
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove code duplication in PolicyCatalog [polaris]
Posted by "nandorKollar (via GitHub)" <gi...@apache.org>.
nandorKollar commented on PR #3846:
URL: https://github.com/apache/polaris/pull/3846#issuecomment-3934401643
Interestingly enough, my local build passed with the same JDK version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove code duplication in PolicyCatalog [polaris]
Posted by "nandorKollar (via GitHub)" <gi...@apache.org>.
nandorKollar commented on PR #3846:
URL: https://github.com/apache/polaris/pull/3846#issuecomment-3958876181
> CI failure:
>
> ```
> Execution failed for task ':polaris-runtime-service:compileJava'.
> > Compilation failed; see the compiler output below.
> /home/runner/work/polaris/polaris/runtime/service/src/main/java/org/apache/polaris/service/catalog/policy/PolicyCatalog.java:287: error: cannot find symbol
> @Nonnull PolicyAttachmentTarget target,
> ^
> symbol: class Nonnull
> location: class PolicyCatalog
> 2 errors
> ```
Yes, that's clear, but with the same JDK, same command, on my local env, it compiles. Also, note that annotation (Nonnull) is imported, and was used in this file before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove code duplication in PolicyCatalog [polaris]
Posted by "nandorKollar (via GitHub)" <gi...@apache.org>.
nandorKollar commented on PR #3846:
URL: https://github.com/apache/polaris/pull/3846#issuecomment-3959058438
Closing this, as it was merged in #3781. The only difference is in fact the @Nonull constraints for the method parameters, but I guess that doesn't matter much.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org