You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by vofque <gi...@git.apache.org> on 2018/10/18 15:06:04 UTC

[GitHub] spark pull request #22767: [SPARK-21402][SQL][BACKPORT-2.3] Fix java array o...

GitHub user vofque opened a pull request:

    https://github.com/apache/spark/pull/22767

    [SPARK-21402][SQL][BACKPORT-2.3] Fix java array of structs deserialization

    This PR is to backport #22708 to branch 2.3.
    
    ## What changes were proposed in this pull request?
    
    MapObjects expression is used to map array elements to java beans. Struct type of elements is inferred from java bean structure and ends up with mixed up field order.
    I used UnresolvedMapObjects instead of MapObjects, which allows to provide element type for MapObjects during analysis based on the resolved input data, not on the java bean.
    
    ## How was this patch tested?
    
    Added a test case.
    Built complete project on travis.
    
    @dongjoon-hyun @cloud-fan

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vofque/spark SPARK-21402-2.3

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/22767.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #22767
    
----
commit a9494a4c8d6298818bc88ba1ceb894604fd6a3c7
Author: Vladimir Kuriatkov <vl...@...>
Date:   2018-10-11T12:56:15Z

    Java array of structs deserialization fixed

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22767: [SPARK-21402][SQL][BACKPORT-2.3] Fix java array of struc...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22767
  
    **[Test build #97546 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97546/testReport)** for PR 22767 at commit [`a9494a4`](https://github.com/apache/spark/commit/a9494a4c8d6298818bc88ba1ceb894604fd6a3c7).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22767: [SPARK-21402][SQL][BACKPORT-2.3] Fix java array of struc...

Posted by dongjoon-hyun <gi...@git.apache.org>.

Github user dongjoon-hyun commented on the issue:

    https://github.com/apache/spark/pull/22767
  
    BTW, this patch have only the following author and it seems to be not linked to GitHub.
    ```
    Authored-by: Vladimir Kuriatkov <Vl...@epam.com>
    Signed-off-by: Dongjoon Hyun <do...@apache.org>
    ```


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22767: [SPARK-21402][SQL][BACKPORT-2.3] Fix java array of struc...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22767
  
    Can one of the admins verify this patch?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22767: [SPARK-21402][SQL][BACKPORT-2.3] Fix java array of struc...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22767
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97546/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22767: [SPARK-21402][SQL][BACKPORT-2.3] Fix java array of struc...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22767
  
    Can one of the admins verify this patch?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22767: [SPARK-21402][SQL][BACKPORT-2.3] Fix java array of struc...

Posted by dongjoon-hyun <gi...@git.apache.org>.

Github user dongjoon-hyun commented on the issue:

    https://github.com/apache/spark/pull/22767
  
    Since this is merged, please close this PR, too. Thanks again.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22767: [SPARK-21402][SQL][BACKPORT-2.3] Fix java array of struc...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22767
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22767: [SPARK-21402][SQL][BACKPORT-2.3] Fix java array of struc...

Posted by dongjoon-hyun <gi...@git.apache.org>.

Github user dongjoon-hyun commented on the issue:

    https://github.com/apache/spark/pull/22767
  
    ok to test


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22767: [SPARK-21402][SQL][BACKPORT-2.3] Fix java array of struc...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22767
  
    **[Test build #97546 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97546/testReport)** for PR 22767 at commit [`a9494a4`](https://github.com/apache/spark/commit/a9494a4c8d6298818bc88ba1ceb894604fd6a3c7).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org