You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/02/10 12:56:30 UTC
[GitHub] [cloudstack] nvazquez opened a new pull request #5980: [Vmware] Prevent NPE on template registration if guest OS is removed
nvazquez opened a new pull request #5980:
URL: https://github.com/apache/cloudstack/pull/5980
### Description
This PR fixes an NPE at template installation for Vmware 'Read VM settings from OVA', in case the matches guest OS is removed from database in CloudStack
````
2022-02-06 14:46:23,651 DEBUG [o.a.c.s.i.d.DeployAsIsHelperImpl] (RemoteHostEndPoint-1:ctx-602c7d2b) (logid:5cd127a6) Persisting template details hardware-item-GraphicsController-8 from OVF properties for template 398
2022-02-06 14:46:23,659 INFO [o.a.c.s.i.d.DeployAsIsHelperImpl] (RemoteHostEndPoint-1:ctx-602c7d2b) (logid:5cd127a6) Guest OS information retrieved from the template: windows9Server64Guest - Microsoft Windows Server 2016 or later (64-bit)
2022-02-06 14:46:23,661 INFO [o.a.c.s.i.d.DeployAsIsHelperImpl] (RemoteHostEndPoint-1:ctx-602c7d2b) (logid:5cd127a6) Minimum hardware version vmx-15 matched to hypervisor version 6.7. Checking guest OS supporting this version
2022-02-06 14:46:23,673 ERROR [o.a.c.s.i.d.DeployAsIsHelperImpl] (RemoteHostEndPoint-1:ctx-602c7d2b) (logid:5cd127a6) Error persisting deploy-as-is details for template 398
java.lang.NullPointerException
at org.apache.cloudstack.storage.image.deployasis.DeployAsIsHelperImpl.retrieveTemplateGuestOsIdFromGuestOsInfo(DeployAsIsHelperImpl.java:178)
at org.apache.cloudstack.storage.image.deployasis.DeployAsIsHelperImpl.handleGuestOsFromOVFDescriptor(DeployAsIsHelperImpl.java:202)
at org.apache.cloudstack.storage.image.deployasis.DeployAsIsHelperImpl.persistTemplateDeployAsIsDetails(DeployAsIsHelperImpl.java:136)
at org.apache.cloudstack.storage.image.BaseImageStoreDriverImpl.createTemplateAsyncCallback(BaseImageStoreDriverImpl.java:210)
at jdk.internal.reflect.GeneratedMethodAccessor178.invoke(Unknown Source)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
````
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [x] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
- Update a record on guest_os table set removed = now() to simulate its deletion
- Register template from URL selecting 'Read VM settings from OVA', assuming the template guest OS matches the removed guest OS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5980: [Vmware] Prevent NPE on template registration if guest OS is removed
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5980:
URL: https://github.com/apache/cloudstack/pull/5980#issuecomment-1035120039
@blueorangutan test centos7 vmware67-u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5980: [Vmware] Prevent NPE on template registration if guest OS is removed
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5980:
URL: https://github.com/apache/cloudstack/pull/5980#issuecomment-1035121178
@nvazquez unsupported parameters provided. Supported mgmt server os are: `suse15, centos7, centos6, alma8, ubuntu18, ubuntu20, rocky8`. Supported hypervisors are: `kvm-centos6, kvm-centos7, kvm-rocky8, kvm-alma8, kvm-ubuntu18, kvm-ubuntu20, kvm-suse15, vmware-55u3, vmware-60u2, vmware-65u2, vmware-67u3, vmware-70u1, vmware-70u2, vmware-70u3, xenserver-65sp1, xenserver-71, xenserver-74, xcpng74, xcpng76, xcpng80, xcpng81, xcpng82`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5980: [Vmware] Prevent NPE on template registration if guest OS is removed
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5980:
URL: https://github.com/apache/cloudstack/pull/5980#issuecomment-1035169967
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5980: [Vmware] Prevent NPE on template registration if guest OS is removed
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5980:
URL: https://github.com/apache/cloudstack/pull/5980#issuecomment-1034890469
@bluerangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez merged pull request #5980: [Vmware] Prevent NPE on template registration if guest OS is removed
Posted by GitBox <gi...@apache.org>.
nvazquez merged pull request #5980:
URL: https://github.com/apache/cloudstack/pull/5980
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5980: [Vmware] Prevent NPE on template registration if guest OS is removed
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5980:
URL: https://github.com/apache/cloudstack/pull/5980#issuecomment-1034928219
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2570
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5980: [Vmware] Prevent NPE on template registration if guest OS is removed
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5980:
URL: https://github.com/apache/cloudstack/pull/5980#issuecomment-1035846581
<b>Trillian test result (tid-3292)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35911 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5980-t3292-vmware-67u3.zip
Smoke tests completed. 90 look OK, 2 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_offline_migrate_VM_and_root_volume | `Error` | 88.84 | test_vm_life_cycle.py
test_03_live_migrate_VM_with_two_data_disks | `Error` | 56.42 | test_vm_life_cycle.py
test_06_disk_offering_strictness_false | `Error` | 143.96 | test_service_offerings.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5980: [Vmware] Prevent NPE on template registration if guest OS is removed
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5980:
URL: https://github.com/apache/cloudstack/pull/5980#issuecomment-1035168381
@blueorangutan test centos7 vmware-67u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5980: [Vmware] Prevent NPE on template registration if guest OS is removed
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5980:
URL: https://github.com/apache/cloudstack/pull/5980#issuecomment-1036068155
Merge based on approvals, failing tests are known issues not related to this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5980: [Vmware] Prevent NPE on template registration if guest OS is removed
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5980:
URL: https://github.com/apache/cloudstack/pull/5980#issuecomment-1034890899
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez edited a comment on pull request #5980: [Vmware] Prevent NPE on template registration if guest OS is removed
Posted by GitBox <gi...@apache.org>.
nvazquez edited a comment on pull request #5980:
URL: https://github.com/apache/cloudstack/pull/5980#issuecomment-1034890469
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org