You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@echarts.apache.org by GitBox <gi...@apache.org> on 2018/10/17 03:00:49 UTC
[GitHub] cuijian-dexter commented on a change in pull request #8997: Pie
chart adds filterValue parameter
cuijian-dexter commented on a change in pull request #8997: Pie chart adds filterValue parameter
URL: https://github.com/apache/incubator-echarts/pull/8997#discussion_r225762482
##########
File path: src/chart/pie/PieView.js
##########
@@ -211,7 +211,20 @@ piePieceProto.updateData = function (data, idx, firstCreate) {
graphic.setHoverStyle(this);
};
-piePieceProto._updateLabel = function (data, idx) {
+piePieceProto._getFilterIgnore = function(data, idx) {
Review comment:
Can the function name be `_getLabelDisplayThreshold` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@echarts.apache.org
For additional commands, e-mail: dev-help@echarts.apache.org