You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Christian Grobmeier <gr...@gmail.com> on 2009/02/15 11:44:27 UTC
[compress] patch for SANDBOX-183
Hi all,
I have improved the testcases for SANDBOX-183.
The patch is attached here:
https://issues.apache.org/jira/browse/SANDBOX-183
Here are the changes in the patch:
ChangeSet: removed System.out.println
AbstracTestCase: added a method which adds the src/test/resources
folder to the classpath. This is cool when starting the JUnit from
eclipse. Additionally two new helper which create zipfiles and help
with checking the content.
DetectArchiverTestCase: extends from AbstractTestCase to get the "add
to eclipse classpath" feature
ZipTestCase: built in one assertion
ChangeSetTestCase: several business logic testcases and assertion
stuff. Assertions fail at the moment, but this is due to
ChangeSet-Implementation bugs.
src/test/resources: New files for better testcases
There is enough work in testcases left, but since this patch has grown
big, I would like to see it applied before I go on. Hope you like it
:-)
Cheers + Thanks
Chris
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [compress] patch for SANDBOX-183
Posted by Christian Grobmeier <gr...@gmail.com>.
Hi,
> Four of the tests fail if I apply the patch:
>
> Failed tests:
> testDeleteDir(org.apache.commons.compress.changes.ChangeSetTestCase)
> testDeletePlusAdd(org.apache.commons.compress.changes.ChangeSetTestCase)
> testAddDeleteAdd(org.apache.commons.compress.changes.ChangeSetTestCase)
> testDeleteAddDelete(org.apache.commons.compress.changes.ChangeSetTestCase)
>
> I've disabled those tests and changed AbstractTestCase to actually log
> why it fails. In each of the four cases there is an enexpected entry
> inside the archive:
>
> testDeleteDir unexpected entry: bla/test4.xml
> testDeletePlusAdd unexpected entry: bla/test4.xml
> testAddDeleteAdd unexpected entry: blub/test.txt
> testDeleteAddDelete unexpected entry: bla/test.txt
yes, I know that. The ChangeSet Implementation isn't finished
currently. We (means: Torsten and myself) spoke at the list about the
expected results, and I implemented them. Now I have to work on the
ChangeSet itself to provide the expected results.
> In a follow-up commit I fixed whitespace. Please set your editor to
> not use any TABs at all.
OK, will do. Sorry for that.
Cheers + thanks for the commit,
Christian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [compress] patch for SANDBOX-183
Posted by Stefan Bodewig <bo...@apache.org>.
On 2009-02-15, Christian Grobmeier <gr...@gmail.com> wrote:
> I have improved the testcases for SANDBOX-183.
> The patch is attached here:
> https://issues.apache.org/jira/browse/SANDBOX-183
Four of the tests fail if I apply the patch:
Failed tests:
testDeleteDir(org.apache.commons.compress.changes.ChangeSetTestCase)
testDeletePlusAdd(org.apache.commons.compress.changes.ChangeSetTestCase)
testAddDeleteAdd(org.apache.commons.compress.changes.ChangeSetTestCase)
testDeleteAddDelete(org.apache.commons.compress.changes.ChangeSetTestCase)
I've disabled those tests and changed AbstractTestCase to actually log
why it fails. In each of the four cases there is an enexpected entry
inside the archive:
testDeleteDir unexpected entry: bla/test4.xml
testDeletePlusAdd unexpected entry: bla/test4.xml
testAddDeleteAdd unexpected entry: blub/test.txt
testDeleteAddDelete unexpected entry: bla/test.txt
> Here are the changes in the patch:
> ChangeSet: removed System.out.println
Good.
> There is enough work in testcases left, but since this patch has grown
> big, I would like to see it applied before I go on. Hope you like it
>> -)
Like I said, I slightly modified it before committing it.
In a follow-up commit I fixed whitespace. Please set your editor to
not use any TABs at all.
Stefan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org