You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@ratis.apache.org by GitBox <gi...@apache.org> on 2022/08/03 20:18:32 UTC

[GitHub] [ratis] adoroszlai commented on a diff in pull request #702: RATIS-1656. Leftover usage of ForkJoinPool.commonPool() in RaftServerImpl

adoroszlai commented on code in PR #702:
URL: https://github.com/apache/ratis/pull/702#discussion_r937094874


##########
ratis-server/src/main/java/org/apache/ratis/server/impl/RaftServerImpl.java:
##########
@@ -1413,7 +1413,7 @@ leaderId, getMemberId(), currentTerm, followerCommit, state.getNextIndex(), NOT_
             getRaftServer().getPeer());
       }
     }
-    return JavaUtils.allOf(futures).whenCompleteAsync(
+    return JavaUtils.allOf(futures).whenComplete(

Review Comment:
   Thanks @szetszwo for the review.  Passing `serverExecutor` was my first attempt, but it caused timeout in `TestInstallSnapshotNotificationWithGrpc`:
   
   https://github.com/adoroszlai/incubator-ratis/runs/7650650577?check_suite_focus=true#step:5:2830
   
   It may indicate that the test or some other part of Ratis needs further tweak.  I'll take another look.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org