[GitHub] [hudi] danny0405 commented on a diff in pull request #8163: [HUDI-5921] Partition path should be considered in BucketIndexConcurrentFileWritesConflictResolutionStrategy

["danny0405 (via GitHub)" <gi...@apache.org>]

danny0405 commented on code in PR #8163:
URL: https://github.com/apache/hudi/pull/8163#discussion_r1134812808


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/utils/TransactionUtils.java:
##########
@@ -78,7 +79,13 @@ public static Option<HoodieCommitMetadata> resolveWriteConflictIfAny(
       final ConcurrentOperation thisOperation = new ConcurrentOperation(currentTxnOwnerInstant.get(), thisCommitMetadata.orElse(new HoodieCommitMetadata()));
       instantStream.forEach(instant -> {
         try {
-          ConcurrentOperation otherOperation = new ConcurrentOperation(instant, table.getMetaClient());
+          ConcurrentOperation otherOperation;
+          if (resolutionStrategy.getClass().getName().equals(BucketIndexConcurrentFileWritesConflictResolutionStrategy.class.getName())) {
+            otherOperation = new ConcurrentOperation(instant, TimelineUtils.getCommitMetadata(instant,
+                reloadActiveTimeline ? table.getMetaClient().reloadActiveTimeline() : table.getActiveTimeline()));
+          } else {

Review Comment:
   do we need to realod the timeline for each instant ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org