You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Izaak Rubin (JIRA)" <ji...@apache.org> on 2008/08/20 20:16:44 UTC

[jira] Issue Comment Edited: (HBASE-841) Consolidate multiple overloaded methods in HRegionInterface, HRegionServer

    [ https://issues.apache.org/jira/browse/HBASE-841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12624077#action_12624077 ] 

irubin edited comment on HBASE-841 at 8/20/08 11:15 AM:
-------------------------------------------------------------

The redundant HRegionServer methods pass on their redundancy to HRegion.  Do we also want to trim the redundancy in HRegion?  A wider variety of classes use HRegion and would have to be modified if we change that too - not that this is a problem, but do we want to leave in some of the client convenience?

Answer: Yes, trim it all.  I'm on it.

      was (Author: irubin):
    The redundant HRegionServer methods pass on their redundancy to HRegion.  Do we also want to trim the redundancy in HRegion?  A wider variety of classes use HRegion and would have to be modified if we change that too - not that this is a problem, but do we want to leave in some of the client convenience?
  
> Consolidate multiple overloaded methods in HRegionInterface, HRegionServer
> --------------------------------------------------------------------------
>
>                 Key: HBASE-841
>                 URL: https://issues.apache.org/jira/browse/HBASE-841
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: ipc, regionserver
>    Affects Versions: 0.2.0
>            Reporter: Jim Kellerman
>            Assignee: Izaak Rubin
>             Fix For: 0.3.0
>
>
> There are too many overloaded methods in HRegionServerInterface and consequently HRegionServer.
> These should be consolidated into one method per operation and the client should pass the appropriate parameters to the server.
> On the server side, the single method should be able to handle parameters that are not supplied, e.g.,
> - long values that are not supplied should be -1
> - boolean values should be supplied appropriately
> - objects that are not supplied should be passed as null
> All these overloaded methods eventually call the same method on the server side eventually. Removing the overloads would make following control flow easier.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.