You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2016/10/06 01:43:51 UTC

[kudu-CR] KUDU-1681: DNS resolution failure of master hostname causes tserver crash

Hello Adar Dembo, Todd Lipcon,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/4640

to review the following change.

Change subject: KUDU-1681: DNS resolution failure of master hostname causes tserver crash
......................................................................

KUDU-1681: DNS resolution failure of master hostname causes tserver crash

Also changes the fail_dns_resolution flag to make DNS resolution return
an error Status instead of an empty resolved list. From the manpage of
getaddrinfo:

    After a successful call to getaddrinfo(), *res is a pointer to a
    linked list of one or more addrinfo structures.

Change-Id: Ib79973a38bebbe84df419e274c08c8cc0c5d31cd
---
M src/kudu/tserver/heartbeater.cc
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/util/net/net_util.cc
3 files changed, 15 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/4640/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4640
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib79973a38bebbe84df419e274c08c8cc0c5d31cd
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] KUDU-1681: DNS resolution failure of master hostname causes tserver crash

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: KUDU-1681: DNS resolution failure of master hostname causes tserver crash
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4640/1/src/kudu/tserver/tablet_server-test.cc
File src/kudu/tserver/tablet_server-test.cc:

Line 2343:   google::FlagSaver saver;
No need to do this, since it's built into the test base class


-- 
To view, visit http://gerrit.cloudera.org:8080/4640
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib79973a38bebbe84df419e274c08c8cc0c5d31cd
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1681: DNS resolution failure of master hostname causes tserver crash

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/4640

to look at the new patch set (#2).

Change subject: KUDU-1681: DNS resolution failure of master hostname causes tserver crash
......................................................................

KUDU-1681: DNS resolution failure of master hostname causes tserver crash

Also changes the fail_dns_resolution flag to make DNS resolution return
an error Status instead of an empty resolved list. From the manpage of
getaddrinfo:

    After a successful call to getaddrinfo(), *res is a pointer to a
    linked list of one or more addrinfo structures.

Change-Id: Ib79973a38bebbe84df419e274c08c8cc0c5d31cd
---
M src/kudu/tserver/heartbeater.cc
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/util/net/net_util.cc
3 files changed, 14 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/4640/2
-- 
To view, visit http://gerrit.cloudera.org:8080/4640
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib79973a38bebbe84df419e274c08c8cc0c5d31cd
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] KUDU-1681: DNS resolution failure of master hostname causes tserver crash

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged.

Change subject: KUDU-1681: DNS resolution failure of master hostname causes tserver crash
......................................................................


KUDU-1681: DNS resolution failure of master hostname causes tserver crash

Also changes the fail_dns_resolution flag to make DNS resolution return
an error Status instead of an empty resolved list. From the manpage of
getaddrinfo:

    After a successful call to getaddrinfo(), *res is a pointer to a
    linked list of one or more addrinfo structures.

Change-Id: Ib79973a38bebbe84df419e274c08c8cc0c5d31cd
Reviewed-on: http://gerrit.cloudera.org:8080/4640
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/tserver/heartbeater.cc
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/util/net/net_util.cc
3 files changed, 14 insertions(+), 5 deletions(-)

Approvals:
  Todd Lipcon: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/4640
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib79973a38bebbe84df419e274c08c8cc0c5d31cd
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] KUDU-1681: DNS resolution failure of master hostname causes tserver crash

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.

Change subject: KUDU-1681: DNS resolution failure of master hostname causes tserver crash
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4640/1/src/kudu/tserver/tablet_server-test.cc
File src/kudu/tserver/tablet_server-test.cc:

Line 2343:   google::FlagSaver saver;
> No need to do this, since it's built into the test base class
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4640
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib79973a38bebbe84df419e274c08c8cc0c5d31cd
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1681: DNS resolution failure of master hostname causes tserver crash

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.

Change subject: KUDU-1681: DNS resolution failure of master hostname causes tserver crash
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4640/2/src/kudu/util/net/net_util.cc
File src/kudu/util/net/net_util.cc:

PS2, Line 144:   if (PREDICT_FALSE(FLAGS_fail_dns_resolution)) {
             :     return Status::NetworkError("injected DNS resolution failure");
             :   }
> Nit: does it make sense to move it before the for() cycle which populates t
I considered moving it, but I thought it would be better to preserve actual failures instead of the injected failure, in the case where that happens.  There shouldn't be any observable difference otherwise.


-- 
To view, visit http://gerrit.cloudera.org:8080/4640
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib79973a38bebbe84df419e274c08c8cc0c5d31cd
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1681: DNS resolution failure of master hostname causes tserver crash

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: KUDU-1681: DNS resolution failure of master hostname causes tserver crash
......................................................................


Patch Set 2: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/4640
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib79973a38bebbe84df419e274c08c8cc0c5d31cd
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] KUDU-1681: DNS resolution failure of master hostname causes tserver crash

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.

Change subject: KUDU-1681: DNS resolution failure of master hostname causes tserver crash
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4640/2/src/kudu/util/net/net_util.cc
File src/kudu/util/net/net_util.cc:

PS2, Line 144:   if (PREDICT_FALSE(FLAGS_fail_dns_resolution)) {
             :     return Status::NetworkError("injected DNS resolution failure");
             :   }
Nit: does it make sense to move it before the for() cycle which populates the addresses output parameter?


-- 
To view, visit http://gerrit.cloudera.org:8080/4640
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib79973a38bebbe84df419e274c08c8cc0c5d31cd
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes