You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Christine Poerschke (Jira)" <ji...@apache.org> on 2020/12/22 14:49:00 UTC
[jira] [Created] (SOLR-15057) avoid unnecessary object retention in
FacetRangeProcessor
Christine Poerschke created SOLR-15057:
------------------------------------------
Summary: avoid unnecessary object retention in FacetRangeProcessor
Key: SOLR-15057
URL: https://issues.apache.org/jira/browse/SOLR-15057
Project: Solr
Issue Type: Task
Reporter: Christine Poerschke
Assignee: Christine Poerschke
(pull request to follow)
* The (private) {{doSubs}} method is a no-op if there are no sub-facets.
* The (private) {{intersections}} and {{filters}} arrays are only used by the {{doSubs}} method.
* The (private) {{rangeStats}} method currently always populates the {{intersections}} and {{filters}} arrays, even when nothing actually subsequently uses them.
* If {{rangeStats}} only populated the {{intersections}} array when it's actually needed then the {{DocSet intersection}} object would remain local in scope and hence the garbage collector could collect it earlier.
[https://github.com/apache/lucene-solr/blob/releases/lucene-solr/8.7.0/solr/core/src/java/org/apache/solr/search/facet/FacetRangeProcessor.java#L531-L555]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org