[GitHub] [arrow] kou commented on a diff in pull request #36522: GH-36456: [CI][R] Unlink system OpenSSL to avoid mixing OpenSSL versions

["kou (via GitHub)" <gi...@apache.org>]

kou commented on code in PR #36522:
URL: https://github.com/apache/arrow/pull/36522#discussion_r1260509392


##########
dev/tasks/r/github.macos.autobrew.yml:
##########
@@ -72,8 +78,10 @@ jobs:
           ARROW_USE_PKG_CONFIG: false
           ARROW_R_DEV: true
           FORCE_AUTOBREW: true
-        {{ macros.github_set_sccache_envvars()|indent(8)}}  
-        run: arrow/ci/scripts/r_test.sh arrow
+        {{ macros.github_set_sccache_envvars()|indent(8)}}
+        run: |
+          find / 2>&1 | grep include/openssl || :
+          arrow/ci/scripts/r_test.sh arrow

Review Comment:
   Yes. It's just a debug print.
   I want to find OpenSSl header files in the system but I couldn't find them... 



##########
dev/tasks/r/github.macos.autobrew.yml:
##########
@@ -35,14 +35,20 @@ jobs:
             - "{{ macros.r_oldrel.ver }}"
     steps:
       {{ macros.github_checkout_arrow()|indent }}
+      - name: Setup hosted
+        if: matrix.platform != 'macos-10.13'
+        run: |
+          # minio and sccache are pre-installed on the self-hosted 10.13 runner.
+          # Install minio for tests.
+          brew install minio
+          brew install sccache
+
+          # Ensure removing OpenSSL from the default paths to avoid
+          # mixing OpenSSL in the default paths and OpenSSL installed
+          # by autobrew.
+          brew unlink openssl || :

Review Comment:
   I think that it's difficult.
   
   For example, please consider the following case:
   * OpenSSL 1.1 is installed in `/usr/local`
   * OpenSSL 3 is install in `/opt/openssl`
   * c-ares is installed in `/usr/local`
   * Build bundled gRPC with c-ares and OpenSSL 3
   * gRPC uses `-I/usr/local/include` from c-ares and `-I/opt/openssl/include` from OpenSSL 3
   * `-I/opt/openssl/include -I/usr/local/include` will work but `-I/usr/local/include -I/opt/openssl/include` will not work because OpenSSl 1.1 headers in `/usr/local/include` are used
   * I don't think that we can always use include flags from OpenSSL 3 as the first include flag because there are more version mixable libraries such as Abseil



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org