You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by jklukas <gi...@git.apache.org> on 2016/05/10 20:58:48 UTC

[GitHub] kafka pull request: MINOR: Expose KafkaStreams Metrics in public A...

GitHub user jklukas opened a pull request:

    https://github.com/apache/kafka/pull/1362

    MINOR: Expose KafkaStreams Metrics in public API

    The Kafka clients expose their metrics registries through a `metrics` method presenting an unmodifiable collection (see [KafkaProducer's metrics() method](https://github.com/apache/kafka/blob/2790d0cb1fc6ade216f2c1bf2667a0ebb53d85e3/clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java#L609-L615)), but `KafkaStreams` does not expose its registry.
    
    This PR exposes an unmodifiable collection of metrics on `KafkaStreams` in direct analogy to `KafkaProducer`.
    
    This contribution is my original work and I license the work to the project under the project's open source license.
    
    cc @guozhangwang @miguno @mjsax 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jklukas/kafka expose-streams-metrics

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/1362.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1362
    
----
commit 1e414d41c47bc04feb498a57d46f20bd1f582012
Author: Jeff Klukas <je...@klukas.net>
Date:   2016-05-10T20:51:46Z

    Expose KafkaStreams Metrics in public API

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request: KAFKA-3701: Expose KafkaStreams Metrics in pub...

Posted by jklukas <gi...@git.apache.org>.
Github user jklukas closed the pull request at:

    https://github.com/apache/kafka/pull/1362


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---