You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/03/21 02:31:42 UTC
[GitHub] [pulsar] fantapsody opened a new pull request #6579: [docker] Do
not apply env values to pulsar_env.sh and bkenv.sh implicitly
fantapsody opened a new pull request #6579: [docker] Do not apply env values to pulsar_env.sh and bkenv.sh implicitly
URL: https://github.com/apache/pulsar/pull/6579
### Motivation
The script `apply-config-from-env.py` always applies env config to env scripts. However, with the changes from https://github.com/apache/pulsar/pull/4105 and https://github.com/apache/pulsar/pull/5892, it seems there is no need to do so anymore. On the other hand, it will interfere with the bash variable replacement mechanisms by replacing the values in scripts directly.
### Modifications
Remove `['conf/pulsar_env.sh', 'conf/bkenv.sh']` from `conf_files`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] sijie merged pull request #6579: [docker] Do not apply env
values to pulsar_env.sh and bkenv.sh implicitly
Posted by GitBox <gi...@apache.org>.
sijie merged pull request #6579: [docker] Do not apply env values to pulsar_env.sh and bkenv.sh implicitly
URL: https://github.com/apache/pulsar/pull/6579
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] jiazhai commented on issue #6579: [docker] Do not apply
env values to pulsar_env.sh and bkenv.sh implicitly
Posted by GitBox <gi...@apache.org>.
jiazhai commented on issue #6579: [docker] Do not apply env values to pulsar_env.sh and bkenv.sh implicitly
URL: https://github.com/apache/pulsar/pull/6579#issuecomment-602140279
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] sijie commented on issue #6579: [docker] Do not apply env
values to pulsar_env.sh and bkenv.sh implicitly
Posted by GitBox <gi...@apache.org>.
sijie commented on issue #6579: [docker] Do not apply env values to pulsar_env.sh and bkenv.sh implicitly
URL: https://github.com/apache/pulsar/pull/6579#issuecomment-603647071
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] cckellogg commented on issue #6579: [docker] Do not apply
env values to pulsar_env.sh and bkenv.sh implicitly
Posted by GitBox <gi...@apache.org>.
cckellogg commented on issue #6579: [docker] Do not apply env values to pulsar_env.sh and bkenv.sh implicitly
URL: https://github.com/apache/pulsar/pull/6579#issuecomment-602327009
Seems fine to me. I would double check kubernetes files and helm charts to make sure this does not accidentally break something.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] jiazhai commented on issue #6579: [docker] Do not apply
env values to pulsar_env.sh and bkenv.sh implicitly
Posted by GitBox <gi...@apache.org>.
jiazhai commented on issue #6579: [docker] Do not apply env values to pulsar_env.sh and bkenv.sh implicitly
URL: https://github.com/apache/pulsar/pull/6579#issuecomment-602140262
Thanks @fantapsody for the work.
@cckellogg Would you please also take a look at this change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] jiazhai commented on issue #6579: [docker] Do not apply
env values to pulsar_env.sh and bkenv.sh implicitly
Posted by GitBox <gi...@apache.org>.
jiazhai commented on issue #6579: [docker] Do not apply env values to pulsar_env.sh and bkenv.sh implicitly
URL: https://github.com/apache/pulsar/pull/6579#issuecomment-602537877
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services