You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "handsomewu6688-design (via GitHub)" <gi...@apache.org> on 2026/05/19 09:53:24 UTC

[PR] Upgrade Java 8 to Java 17 via OpenRewrite UpgradeToJava17 recipe [commons-lang]

handsomewu6688-design opened a new pull request, #1662:
URL: https://github.com/apache/commons-lang/pull/1662

   ## Summary
   
   This PR upgrades the project from Java 8 to Java 17 using the OpenRewrite org.openrewrite.java.migrate.UpgradeToJava17 recipe, applied via the rewrite-maven-plugin.
   
   ## Changes Applied
   
   - UpgradeJavaVersion: Updated source/target from 8 to 17 in pom.xml
   - InstanceOfPatternMatch: Replaced instanceof + cast with pattern matching
   - AddSerialAnnotationToSerialVersionUID: Added @Serial annotation to serialVersionUID fields
   - StringFormatted: Converted String.format to .formatted
   - PathsGetToPathOf: Replaced Paths.get with Path.of
   - OptionalNotPresentToIsEmpty: Converted !optional.isPresent to optional.isEmpty
   
   ## Statistics
   
   - 107 files changed, 623 insertions, 576 deletions
   - Estimated manual effort saved: 3 hours 12 minutes
   
   ## Verification
   
   - Built and tested with JDK 17
   - All existing tests pass with the upgraded code
   
   ## Tool
   
   Recipe: org.openrewrite.java.migrate.UpgradeToJava17
   Plugin: rewrite-maven-plugin
   Coordinates: org.openrewrite.recipe:rewrite-migrate-java:LATEST
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Upgrade Java 8 to Java 17 [commons-lang]

Posted by "handsomewu6688-design (via GitHub)" <gi...@apache.org>.
handsomewu6688-design commented on PR #1662:
URL: https://github.com/apache/commons-lang/pull/1662#issuecomment-4504737364

   > -1, this would block the majority of our users. Plus, asking for 107 files to be reviewed is rude.
   
   We apologize for our abrupt pull request — we fully understand this would impact most users and that reviewing 107 files is inappropriate.
   
   We are actively working on JDK version upgrades across multiple open-source projects and collecting community feedback. In fact, we have already helped several repositories successfully complete JDK modernization work.
   
   Our proposal does not involve changing the project’s main branch or Java 8 baseline at all. We simply want to open a dedicated issue to discuss maintaining independent parallel branches for newer LTS JDK versions, while keeping your official code fully untouched. We will take full responsibility for these branches.
   
   Thank you for your time and consideration.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Upgrade Java 8 to Java 17 [commons-lang]

Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory closed pull request #1662: Upgrade Java 8 to Java 17
URL: https://github.com/apache/commons-lang/pull/1662


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Upgrade Java 8 to Java 17 [commons-lang]

Posted by "handsomewu6688-design (via GitHub)" <gi...@apache.org>.
handsomewu6688-design commented on PR #1662:
URL: https://github.com/apache/commons-lang/pull/1662#issuecomment-4504733389

   We apologize for our abrupt pull request — we fully understand this would impact most users and that reviewing 107 files is inappropriate.
   
   We are actively working on JDK version upgrades across multiple open-source projects and collecting community feedback. In fact, we have already helped several repositories successfully complete JDK modernization work.
   
   Our proposal does not involve changing the project’s main branch or Java 8 baseline at all. We simply want to open a dedicated issue to discuss maintaining independent parallel branches for newer LTS JDK versions, while keeping your official code fully untouched. We will take full responsibility for these branches.
   
   Thank you for your time and consideration.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Upgrade Java 8 to Java 17 [commons-lang]

Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #1662:
URL: https://github.com/apache/commons-lang/pull/1662#issuecomment-4487271712

   -1, this would block the majority of our users. Plus, asking for 107 files to be reviewed is rude.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org