You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by ahgittin <gi...@git.apache.org> on 2014/10/30 14:58:18 UTC
[GitHub] incubator-brooklyn pull request: HA info in the docs on persistenc...
GitHub user ahgittin opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/282
HA info in the docs on persistence
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ahgittin/incubator-brooklyn ha
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/282.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #282
----
commit 65b7c9777d50b0a81fa5ae9b6977954ebad117fe
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2014-10-30T13:56:39Z
HA info in the docs on persistence
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: HA info in the docs on persistenc...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/282
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: HA info in the docs on persistenc...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/282#discussion_r19641981
--- Diff: usage/cli/src/main/java/brooklyn/cli/Main.java ---
@@ -321,11 +321,11 @@ private String readLine(InputStream in) throws IOException {
title = "high availability mode",
description =
"The high availability mode. Possible values are: \n"+
- "disabled: management node works in isolation - will not cooperate with any other standby/master nodes in management plane; \n"+
+ "disabled: management node works in isolation; it will not cooperate with any other standby/master nodes in management plane; \n"+
--- End diff --
Unfortunately (last I looked) `io.airlift.command.Cli` strips out the `\n` chars when showing the description. Therefore I prefer `-` as separator rather than semicolon. Without the `\n`, it's hard to tell that the `;` before the next term is different from the semicolon in the middle of the description.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: HA info in the docs on persistenc...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/282#discussion_r19648650
--- Diff: usage/cli/src/main/java/brooklyn/cli/Main.java ---
@@ -321,11 +321,11 @@ private String readLine(InputStream in) throws IOException {
title = "high availability mode",
description =
"The high availability mode. Possible values are: \n"+
- "disabled: management node works in isolation - will not cooperate with any other standby/master nodes in management plane; \n"+
+ "disabled: management node works in isolation; it will not cooperate with any other standby/master nodes in management plane; \n"+
--- End diff --
makes sense, bit naff but the fix is in airlift isn't it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: HA info in the docs on persistenc...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/282#issuecomment-61183459
Looks good. Only one very minor comment. Happy for this to be merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---