[jira] [Commented] (HBASE-14411) Fix UT failures when using multiwal as default provider

["Yu Li (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-14411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14741385#comment-14741385 ] 

Yu Li commented on HBASE-14411:
-------------------------------

One thing to mention here is that most left UT failures are caused by lacking of consideration on using multiple wal rather than fatal issue in current mutiwal implementation, so the fixes would mainly on refining UT codes.

Meanwhile, fixing UT is important since only this way we could make sure multiwal function works well in perspective of developer.

> Fix UT failures when using multiwal as default provider
> -------------------------------------------------------
>
>                 Key: HBASE-14411
>                 URL: https://issues.apache.org/jira/browse/HBASE-14411
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Yu Li
>            Assignee: Yu Li
>             Fix For: 2.0.0
>
>
> If we set hbase.wal.provider to multiwal in hbase-server/src/test/resources/hbase-site.xml which allows us to use BoundedRegionGroupingProvider in UT, we will observe below failures in current code base:
> {noformat}
> Failed tests:
>   TestHLogRecordReader>TestWALRecordReader.testPartialRead:164 expected:<1> but was:<2>
>   TestHLogRecordReader>TestWALRecordReader.testWALRecordReader:216 expected:<2> but was:<3>
>   TestWALRecordReader.testPartialRead:164 expected:<1> but was:<2>
>   TestWALRecordReader.testWALRecordReader:216 expected:<2> but was:<3>
>   TestDistributedLogSplitting.testRecoveredEdits:276 edits dir should have more than a single file in it. instead has 1
>   TestAtomicOperation.testMultiRowMutationMultiThreads:499 expected:<0> but was:<1>
>   TestHRegionServerBulkLoad.testAtomicBulkLoad:307
> Expected: is <true>
>      but: was <false>
>   TestLogRolling.testCompactionRecordDoesntBlockRolling:611 Should have WAL; one table is not flushed expected:<1> but was:<0>
>   TestLogRolling.testLogRollOnDatanodeDeath:359 null
>   TestLogRolling.testLogRollOnPipelineRestart:472 Missing datanode should've triggered a log roll
>   TestReplicationSourceManager.testLogRoll:237 expected:<6> but was:<7>
>   TestReplicationWALReaderManager.test:155 null
>   TestReplicationWALReaderManager.test:155 null
>   TestReplicationWALReaderManager.test:155 null
>   TestReplicationWALReaderManager.test:155 null
>   TestReplicationWALReaderManager.test:155 null
>   TestReplicationWALReaderManager.test:155 null
>   TestReplicationWALReaderManager.test:155 null
>   TestReplicationWALReaderManager.test:155 null
>   TestWALSplit.testCorruptedLogFilesSkipErrorsFalseDoesNotTouchLogs:594 if skip.errors is false all files should remain in place expected:<11> but was:<12>
>   TestWALSplit.testLogsGetArchivedAfterSplit:649 wrong number of files in the archive log expected:<11> but was:<12>
>   TestWALSplit.testMovedWALDuringRecovery:810->retryOverHdfsProblem:793 expected:<11> but was:<12>
>   TestWALSplit.testRetryOpenDuringRecovery:838->retryOverHdfsProblem:793 expected:<11> but was:<12>
>   TestWALSplitCompressed>TestWALSplit.testCorruptedLogFilesSkipErrorsFalseDoesNotTouchLogs:594 if skip.errors is false all files should remain in place expected:<11> but was:<12>
>   TestWALSplitCompressed>TestWALSplit.testLogsGetArchivedAfterSplit:649 wrong number of files in the archive log expected:<11> but was:<12>
>   TestWALSplitCompressed>TestWALSplit.testMovedWALDuringRecovery:810->TestWALSplit.retryOverHdfsProblem:793 expected:<11> but was:<12>
>   TestWALSplitCompressed>TestWALSplit.testRetryOpenDuringRecovery:838->TestWALSplit.retryOverHdfsProblem:793 expected:<11> but was:<12>
> {noformat}
> While patch for HBASE-14306 could resolve failures of TestHLogRecordReader, TestReplicationSourceManager and TestReplicationWALReaderManager, this JIRA will focus on resolving the others



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)