You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/12 14:16:32 UTC
[GitHub] [superset] michael-s-molina opened a new pull request #12452: chore: apply capitalization guidelines - iteration 7 (#12343)
michael-s-molina opened a new pull request #12452:
URL: https://github.com/apache/superset/pull/12452
### SUMMARY
Apply capitalization guidelines defined in #12343.
@junlincc
### TEST PLAN
Check if modified texts are following capitalization guidelines.
### ADDITIONAL INFORMATION
- [x] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas merged pull request #12452: chore: apply capitalization guidelines - iteration 6 (#12343)
Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #12452:
URL: https://github.com/apache/superset/pull/12452
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on pull request #12452: chore: apply capitalization guidelines - iteration 6 (#12343)
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on pull request #12452:
URL: https://github.com/apache/superset/pull/12452#issuecomment-758727223
@Steejay @mihir174 since Design will review this PR, to make it easier for them, please give a list of menu items that has changed in the description. @michael-s-molina
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] adam-stasiak commented on pull request #12452: chore: apply capitalization guidelines - iteration 6 (#12343)
Posted by GitBox <gi...@apache.org>.
adam-stasiak commented on pull request #12452:
URL: https://github.com/apache/superset/pull/12452#issuecomment-758841004
looks good to me - > please restart to make e2e script green ;)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #12452: chore: apply capitalization guidelines - iteration 6 (#12343)
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #12452:
URL: https://github.com/apache/superset/pull/12452#issuecomment-758727223
please specify all your changes in this PR, include screenshot and test plan, also for all your future PRs. @michael-s-molina 🙏
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc removed a comment on pull request #12452: chore: apply capitalization guidelines - iteration 6 (#12343)
Posted by GitBox <gi...@apache.org>.
junlincc removed a comment on pull request #12452:
URL: https://github.com/apache/superset/pull/12452#issuecomment-758727223
@Steejay @mihir174 since Design will review this PR, to make it easier for them, please give a list of menu items that has changed in the description. @michael-s-molina
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org