You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "johnpoth (via GitHub)" <gi...@apache.org> on 2024/03/14 15:04:23 UTC
[PR] Camel 20567 make it possible to define restconfiguration in xml-io-dsl and xml-jaxb-dsl [camel]
johnpoth opened a new pull request, #13488:
URL: https://github.com/apache/camel/pull/13488
# Description
Done in a similar way as the yaml-dsl, hope this is ok! Not sure why it's possible to define [multiple](https://github.com/apache/camel/blob/e6cede73c02c88d83ffd5876090e0072f9ea8e7b/core/camel-core-model/src/main/java/org/apache/camel/model/app/BeansDefinition.java#L92) restConfigurations in xml. It also seems that the xml-io-dsl can handle a root \<camel\> tag while the xml-jaxb-dsl cannot. Thanks !
<!--
- Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
-->
# Target
- [ ] I checked that the commit is targeting the correct branch (note that Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch)
# Tracking
- [ ] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).
<!--
# *Note*: trivial changes like, typos, minor documentation fixes and other small items do not require a JIRA issue. In this case your pull request should address just this issue, without pulling in other changes.
-->
# Apache Camel coding standards and style
- [ ] I checked that each commit in the pull request has a meaningful subject line and body.
<!--
If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
-->
- [ ] I have run `mvn clean install -DskipTests` locally and I have committed all auto-generated changes
<!--
You can run the aforementioned command in your module so that the build auto-formats your code. This will also be verified as part of the checks and your PR may be rejected if if there are uncommited changes after running `mvn clean install -DskipTests`.
You can learn more about the contribution guidelines at https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Camel 20567 make it possible to define restconfiguration in xml-io-dsl and xml-jaxb-dsl [camel]
Posted by "johnpoth (via GitHub)" <gi...@apache.org>.
johnpoth commented on PR #13488:
URL: https://github.com/apache/camel/pull/13488#issuecomment-1999171846
Looks like there are still uncommitted changes ... let me check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Camel 20567 make it possible to define restconfiguration in xml-io-dsl and xml-jaxb-dsl [camel]
Posted by "johnpoth (via GitHub)" <gi...@apache.org>.
johnpoth commented on PR #13488:
URL: https://github.com/apache/camel/pull/13488#issuecomment-1999219966
Looks like I missed some spaces in the commit, should be good now thanks !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Camel 20567 make it possible to define restconfiguration in xml-io-dsl and xml-jaxb-dsl [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13488:
URL: https://github.com/apache/camel/pull/13488#issuecomment-1997670763
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committers, please review the following items:
* First-time contributors **require MANUAL approval** for the GitHub Actions to run
* You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot.
* You can label PRs using `build-all`, `build-dependents`, `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
* Build and test logs are available in the Summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
* :warning: Be careful when sharing logs. Review their contents before sharing them publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Camel 20567 make it possible to define restconfiguration in xml-io-dsl and xml-jaxb-dsl [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #13488:
URL: https://github.com/apache/camel/pull/13488#issuecomment-2002996524
org.apache.camel.dsl.xml.io.XmlLoadAppTest.testLoadCamelAppRestConfiguration | 0.064s | FAILURE
-- | -- | --
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Camel 20567 make it possible to define restconfiguration in xml-io-dsl and xml-jaxb-dsl [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus merged PR #13488:
URL: https://github.com/apache/camel/pull/13488
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Camel 20567 make it possible to define restconfiguration in xml-io-dsl and xml-jaxb-dsl [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #13488:
URL: https://github.com/apache/camel/pull/13488#issuecomment-2003321013
Maybe you can force rebase from main to get the langchain fix, and also your code changes is formatted and this file is changed
/dsl/camel-xml-jaxb-dsl-test/definition/src/test/java/org/apache/camel/dsl/xml/jaxb/definition/LoadRestConfigurationFromXmlTest.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Camel 20567 make it possible to define restconfiguration in xml-io-dsl and xml-jaxb-dsl [camel]
Posted by "johnpoth (via GitHub)" <gi...@apache.org>.
johnpoth commented on PR #13488:
URL: https://github.com/apache/camel/pull/13488#issuecomment-2003440339
thanks @davsclaus , after rebasing and running manually the formatter `mvn -f definition net.revelc.code.formatter:formatter-maven-plugin:2.23.0:format` we should be good ... fingers crossed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Camel 20567 make it possible to define restconfiguration in xml-io-dsl and xml-jaxb-dsl [camel]
Posted by "johnpoth (via GitHub)" <gi...@apache.org>.
johnpoth commented on PR #13488:
URL: https://github.com/apache/camel/pull/13488#issuecomment-1999142016
Thanks @davsclaus @orpiske for reviewing ! I rebased `main`, thanks !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Camel 20567 make it possible to define restconfiguration in xml-io-dsl and xml-jaxb-dsl [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #13488:
URL: https://github.com/apache/camel/pull/13488#issuecomment-1997830840
Can you update this PR as there are modified files
modified: dsl/camel-xml-io-dsl/src/test/java/org/apache/camel/dsl/xml/io/XmlLoadAppTest.java
modified: dsl/camel-xml-jaxb-dsl-test/definition/src/test/java/org/apache/camel/dsl/xml/jaxb/definition/LoadRestConfigurationFromXmlTest.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org