You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ariatosca.apache.org by djay87 <gi...@git.apache.org> on 2017/07/11 10:52:08 UTC
[GitHub] incubator-ariatosca pull request #185: ARIA-277 Support for Type Qualified N...
GitHub user djay87 opened a pull request:
https://github.com/apache/incubator-ariatosca/pull/185
ARIA-277 Support for Type Qualified Name
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/djay87/incubator-ariatosca master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-ariatosca/pull/185.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #185
----
commit 740df7062f536e8716acc07013adf05745cdd172
Author: evyzzae <d....@ericsson.com>
Date: 2017-07-11T10:35:29Z
ARIA-277 Support for Type Qualified Name
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-ariatosca pull request #185: ARIA-277 Support for Type Qualified N...
Posted by djay87 <gi...@git.apache.org>.
Github user djay87 commented on a diff in the pull request:
https://github.com/apache/incubator-ariatosca/pull/185#discussion_r127697932
--- Diff: aria/orchestrator/workflows/core/events_handler.py ---
@@ -147,7 +147,8 @@ def _update_node_state_if_necessary(ctx, is_transitional=False):
# and also will *never* be the type name
--- End diff --
I tried to squash all these commits to one.. could you please check if it is fine now ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-ariatosca issue #185: ARIA-277 Support for Type Qualified Name
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/incubator-ariatosca/pull/185
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-ariatosca pull request #185: ARIA-277 Support for Type Qualified N...
Posted by mxmrlv <gi...@git.apache.org>.
Github user mxmrlv commented on a diff in the pull request:
https://github.com/apache/incubator-ariatosca/pull/185#discussion_r126896663
--- Diff: tests/orchestrator/workflows/core/test_events.py ---
@@ -105,6 +106,39 @@ def test_node_state_changes_as_a_result_of_standard_lifecycle_delete_shorthand_n
ctx, interface_name=SHORTHAND_NAME, op_name='delete', executor=executor)
_assert_node_state_changed_as_a_result_of_standard_lifecycle_operation(node, 'delete')
+def test_node_state_changes_as_a_result_of_standard_lifecycle_create_typequalified_name(ctx,
--- End diff --
Basically this tests module tests the events and the state changes associated with them. Since the shorthand_name and the type_qualified_name are handled the same in that regard, maybe it'd be better to write tests for `get_type_by_full_or_shorthand_or_typequalified_name` and `convert_shorthand_typequalified_to_full_type_name`, and place these under `tests/parser/test_tosca_simple_v1_0/presentation/types.py`, and move the `test_tosca_simple_v1_0.py` module to be under `tests/parser/test_tosca_simple_v1_0/end2end.py`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-ariatosca pull request #185: ARIA-277 Support for Type Qualified N...
Posted by djay87 <gi...@git.apache.org>.
Github user djay87 commented on a diff in the pull request:
https://github.com/apache/incubator-ariatosca/pull/185#discussion_r127697748
--- Diff: tests/orchestrator/workflows/core/test_events.py ---
@@ -105,6 +106,39 @@ def test_node_state_changes_as_a_result_of_standard_lifecycle_delete_shorthand_n
ctx, interface_name=SHORTHAND_NAME, op_name='delete', executor=executor)
_assert_node_state_changed_as_a_result_of_standard_lifecycle_operation(node, 'delete')
+def test_node_state_changes_as_a_result_of_standard_lifecycle_create_typequalified_name(ctx,
--- End diff --
I made these changes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-ariatosca pull request #185: ARIA-277 Support for Type Qualified N...
Posted by mxmrlv <gi...@git.apache.org>.
Github user mxmrlv commented on a diff in the pull request:
https://github.com/apache/incubator-ariatosca/pull/185#discussion_r126893908
--- Diff: extensions/aria_extension_tosca/simple_v1_0/assignments.py ---
@@ -29,8 +29,8 @@
relationship_template_or_type_validator,
capability_definition_or_type_validator,
node_filter_validator)
-from .presentation.types import (convert_shorthand_to_full_type_name,
- get_type_by_full_or_shorthand_name)
+from .presentation.types import (convert_shorthand_typequalified_to_full_type_name,
--- End diff --
can we maybe change the names of the function to convert_name_to_full_type_name
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-ariatosca pull request #185: ARIA-277 Support for Type Qualified N...
Posted by djay87 <gi...@git.apache.org>.
Github user djay87 closed the pull request at:
https://github.com/apache/incubator-ariatosca/pull/185
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-ariatosca pull request #185: ARIA-277 Support for Type Qualified N...
Posted by mxmrlv <gi...@git.apache.org>.
Github user mxmrlv commented on a diff in the pull request:
https://github.com/apache/incubator-ariatosca/pull/185#discussion_r126897001
--- Diff: aria/orchestrator/workflows/core/events_handler.py ---
@@ -147,7 +147,8 @@ def _update_node_state_if_necessary(ctx, is_transitional=False):
# and also will *never* be the type name
--- End diff --
I know we are currently lacking in the contribution guidelines, but can you please squash all of the three commits into a single commit?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---