You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by GitBox <gi...@apache.org> on 2021/05/10 20:56:40 UTC
[GitHub] [qpid-dispatch] ganeshmurthy opened a new pull request #1207: DISPATCH-2110: Formatted numbers correctly in verbose outputs
ganeshmurthy opened a new pull request #1207:
URL: https://github.com/apache/qpid-dispatch/pull/1207
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] ChugR commented on a change in pull request #1207: DISPATCH-2110: Formatted numbers correctly in verbose outputs
Posted by GitBox <gi...@apache.org>.
ChugR commented on a change in pull request #1207:
URL: https://github.com/apache/qpid-dispatch/pull/1207#discussion_r629693320
##########
File path: tools/qdstat.in
##########
@@ -606,7 +606,7 @@ class BusManager(object):
if has_priority:
row.append(addr.priority if addr.priority >= 0 else "-")
Review comment:
Does addr.priority need to be PlainNum'd as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] asfgit closed pull request #1207: DISPATCH-2110: Formatted numbers correctly in verbose outputs
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1207:
URL: https://github.com/apache/qpid-dispatch/pull/1207
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #1207: DISPATCH-2110: Formatted numbers correctly in verbose outputs
Posted by GitBox <gi...@apache.org>.
kgiusti commented on a change in pull request #1207:
URL: https://github.com/apache/qpid-dispatch/pull/1207#discussion_r631825675
##########
File path: tools/qdstat.in
##########
@@ -540,8 +540,12 @@ class BusManager(object):
row.append(PlainNum(node.routerLink))
if self.opts.verbose:
- row.append(get(node, 'protocolVersion'))
- row.append(get(node, 'cost'))
+ row.append(PlainNum(get(node, 'protocolVersion')))
+ cost = get(node, 'cost')
+ if cost:
Review comment:
But that isn't clear from the code on line 548: to me I read
548: row.append(cost)
And I think it's going to output either "0" or "None".
Change line 548 to:
row.append("")
to make it obvious that the output is to be blank. Unless the router treats an unspecified cost as "0". If that's the case then do "row.append("0")" instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #1207: DISPATCH-2110: Formatted numbers correctly in verbose outputs
Posted by GitBox <gi...@apache.org>.
kgiusti commented on a change in pull request #1207:
URL: https://github.com/apache/qpid-dispatch/pull/1207#discussion_r630154298
##########
File path: tools/qdstat.in
##########
@@ -540,8 +540,12 @@ class BusManager(object):
row.append(PlainNum(node.routerLink))
if self.opts.verbose:
- row.append(get(node, 'protocolVersion'))
- row.append(get(node, 'cost'))
+ row.append(PlainNum(get(node, 'protocolVersion')))
+ cost = get(node, 'cost')
+ if cost:
Review comment:
Why the need for the conditional? what is the expected output of the 'else' if cost is '0', or None?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #1207: DISPATCH-2110: Formatted numbers correctly in verbose outputs
Posted by GitBox <gi...@apache.org>.
kgiusti commented on a change in pull request #1207:
URL: https://github.com/apache/qpid-dispatch/pull/1207#discussion_r631825675
##########
File path: tools/qdstat.in
##########
@@ -540,8 +540,12 @@ class BusManager(object):
row.append(PlainNum(node.routerLink))
if self.opts.verbose:
- row.append(get(node, 'protocolVersion'))
- row.append(get(node, 'cost'))
+ row.append(PlainNum(get(node, 'protocolVersion')))
+ cost = get(node, 'cost')
+ if cost:
Review comment:
But that isn't clear from the code on line 548: to me I read
548: row.append(cost)
And I think it's going to output either "0" or "None".
Change line 548 to:
row.append("")
to make it obvious that the output is to be blank.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy commented on a change in pull request #1207: DISPATCH-2110: Formatted numbers correctly in verbose outputs
Posted by GitBox <gi...@apache.org>.
ganeshmurthy commented on a change in pull request #1207:
URL: https://github.com/apache/qpid-dispatch/pull/1207#discussion_r630158746
##########
File path: tools/qdstat.in
##########
@@ -540,8 +540,12 @@ class BusManager(object):
row.append(PlainNum(node.routerLink))
if self.opts.verbose:
- row.append(get(node, 'protocolVersion'))
- row.append(get(node, 'cost'))
+ row.append(PlainNum(get(node, 'protocolVersion')))
+ cost = get(node, 'cost')
+ if cost:
Review comment:
If the cost is zero or None, the output shows blank string
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org