[GitHub] wujimin commented on a change in pull request #949: [SCB-957] delete too old protobuf map compatible flag

[GitBox <gi...@apache.org>]

wujimin commented on a change in pull request #949: [SCB-957] delete too old protobuf map compatible flag
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/949#discussion_r224412887
 
 

 ##########
 File path: transports/transport-highway/src/main/java/org/apache/servicecomb/transport/highway/message/LoginRequest.java
 ##########
 @@ -42,11 +42,12 @@ public static LoginRequest readObject(Buffer bodyBuffer) throws Exception {
   @Tag(2)
   private String zipName;
 
+  // no need this flag any more, but tag(3) should be reserved
   // 历史版本中的protoStuff实现的protobuf的map编码与标准的protobuf不兼容
   // 为保持highway的兼容，旧的不兼容编码也要保留
   // 只有LoginRequest/LoginResponse同时为true时，才使用标准protobuf编码
-  @Tag(3)
-  private boolean useProtobufMapCodec;
+  //@Tag(3)
+  //private boolean useProtobufMapCodec;
 
 Review comment:
   impossible, maybe one years ago  version used the old format

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services