You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "John Russell (Code Review)" <ge...@cloudera.org> on 2017/01/03 19:26:05 UTC
[Impala-ASF-CR] Apply attribute to hide main data source topic in keydef tag, same as in topicref tag.
John Russell has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5592
Change subject: Apply attribute to hide main data source topic in keydef tag, same as in topicref tag.
......................................................................
Apply attribute to hide main data source topic in keydef tag, same as in topicref tag.
Change-Id: I5c7d3bf9a2a2c3fe73873fea95d025d838e987bb
---
M docs/impala.ditamap
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/92/5592/1
--
To view, visit http://gerrit.cloudera.org:8080/5592
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5c7d3bf9a2a2c3fe73873fea95d025d838e987bb
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
[Impala-ASF-CR] Apply attribute to hide main data source topic in keydef tag.
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: Apply attribute to hide main data source topic in keydef tag.
......................................................................
Patch Set 2: Code-Review+2 Verified+1
(2 comments)
I'll +2 this myself after verifying. The noise from warning messages in the doc builds makes it trickier to verify all the other doc CRs.
http://gerrit.cloudera.org:8080/#/c/5592/1//COMMIT_MSG
Commit Message:
Line 7: Apply attribute to hide main data source topic in keydef tag.
> Long line.
Done
http://gerrit.cloudera.org:8080/#/c/5592/1/docs/impala.ditamap
File docs/impala.ditamap:
Line 846: <keydef audience="Cloudera" href="topics/impala_data_sources.xml" keys="data_sources"/>
> The data sources feature has always been considered "not ready for prime ti
Done
--
To view, visit http://gerrit.cloudera.org:8080/5592
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c7d3bf9a2a2c3fe73873fea95d025d838e987bb
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #250
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] Apply attribute to hide main data source topic in keydef tag, same as in topicref tag.
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: Apply attribute to hide main data source topic in keydef tag, same as in topicref tag.
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5592/1/docs/impala.ditamap
File docs/impala.ditamap:
Line 846: <keydef audience="Cloudera" href="topics/impala_data_sources.xml" keys="data_sources"/>
> Why should this be hidden?
The data sources feature has always been considered "not ready for prime time" and the associated doc has never been reviewed or completed. The actual content has always been hidden, I just accidentally left off the audience= attribute when making the corresponding <keydef> tag. The unhidden <keydef> tag has no effect by itself, but it was causing warnings in any doc build.
--
To view, visit http://gerrit.cloudera.org:8080/5592
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c7d3bf9a2a2c3fe73873fea95d025d838e987bb
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #250
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] Apply attribute to hide main data source topic in keydef tag.
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has submitted this change and it was merged.
Change subject: Apply attribute to hide main data source topic in keydef tag.
......................................................................
Apply attribute to hide main data source topic in keydef tag.
Use the same audience= attr as the corresponding topicref tag.
Change-Id: I5c7d3bf9a2a2c3fe73873fea95d025d838e987bb
Reviewed-on: http://gerrit.cloudera.org:8080/5592
Reviewed-by: John Russell <jr...@cloudera.com>
Tested-by: John Russell <jr...@cloudera.com>
---
M docs/impala.ditamap
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
John Russell: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/5592
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5c7d3bf9a2a2c3fe73873fea95d025d838e987bb
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #250
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
[Impala-ASF-CR] Apply attribute to hide main data source topic in keydef tag, same as in topicref tag.
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: Apply attribute to hide main data source topic in keydef tag, same as in topicref tag.
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5592/1//COMMIT_MSG
Commit Message:
Line 7: Apply attribute to hide main data source topic in keydef tag, same as in topicref tag.
Long line.
http://gerrit.cloudera.org:8080/#/c/5592/1/docs/impala.ditamap
File docs/impala.ditamap:
Line 846: <keydef audience="Cloudera" href="topics/impala_data_sources.xml" keys="data_sources"/>
Why should this be hidden?
--
To view, visit http://gerrit.cloudera.org:8080/5592
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c7d3bf9a2a2c3fe73873fea95d025d838e987bb
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #250
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-HasComments: Yes
[Impala-ASF-CR] Apply attribute to hide main data source topic in keydef tag.
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has uploaded a new patch set (#2).
Change subject: Apply attribute to hide main data source topic in keydef tag.
......................................................................
Apply attribute to hide main data source topic in keydef tag.
Use the same audience= attr as the corresponding topicref tag.
Change-Id: I5c7d3bf9a2a2c3fe73873fea95d025d838e987bb
---
M docs/impala.ditamap
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/92/5592/2
--
To view, visit http://gerrit.cloudera.org:8080/5592
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5c7d3bf9a2a2c3fe73873fea95d025d838e987bb
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #250
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>