You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "raiden00pl (via GitHub)" <gi...@apache.org> on 2023/10/16 13:13:24 UTC

[PR] examples/foc: add support for velocity observers [nuttx-apps]

raiden00pl opened a new pull request, #2130:
URL: https://github.com/apache/nuttx-apps/pull/2130

   ## Summary
   examples/foc: add support for velocity observers
   ## Impact
   
   ## Testing
   ESC based on b-g431b-esc
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] examples/foc: add support for velocity observers [nuttx-apps]

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #2130:
URL: https://github.com/apache/nuttx-apps/pull/2130


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] examples/foc: add support for velocity observers [nuttx-apps]

Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on code in PR #2130:
URL: https://github.com/apache/nuttx-apps/pull/2130#discussion_r1361071519


##########
examples/foc/Kconfig:
##########
@@ -98,6 +98,26 @@ config EXAMPLES_FOC_SENSORED
 
 endchoice #
 
+menu "Motor phy"
+
+config EXAMPLES_FOC_MOTOR_POLES
+	int "FOC example motor poles pairs"
+	default 0
+
+config EXAMPLES_FOC_MOTOR_RES
+	int "FOC example motor phase resistance (x1000000)"
+	default 0
+
+config EXAMPLES_FOC_MOTOR_IND
+	int "FOC example motor phase inductance (x1000000)"
+	default 0
+
+config EXAMPLES_FOC_MOTOR_FLUXLINK
+	int "FOC example motor flux link (x1000000)"
+	default 0

Review Comment:
   Please include a help explaining about the value for each unit. The (x1000000) was not simple to figure-out until looking the source code. It could be a "doesn't care" bit or even a hex code.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] examples/foc: add support for velocity observers [nuttx-apps]

Posted by "raiden00pl (via GitHub)" <gi...@apache.org>.
raiden00pl commented on code in PR #2130:
URL: https://github.com/apache/nuttx-apps/pull/2130#discussion_r1361693911


##########
examples/foc/Kconfig:
##########
@@ -98,6 +98,26 @@ config EXAMPLES_FOC_SENSORED
 
 endchoice #
 
+menu "Motor phy"
+
+config EXAMPLES_FOC_MOTOR_POLES
+	int "FOC example motor poles pairs"
+	default 0
+
+config EXAMPLES_FOC_MOTOR_RES
+	int "FOC example motor phase resistance (x1000000)"
+	default 0
+
+config EXAMPLES_FOC_MOTOR_IND
+	int "FOC example motor phase inductance (x1000000)"
+	default 0
+
+config EXAMPLES_FOC_MOTOR_FLUXLINK
+	int "FOC example motor flux link (x1000000)"
+	default 0

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org