You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org> on 2020/09/15 21:52:50 UTC
[Impala-ASF-CR] IMPALA-9227: Add coverage for query retries caused by RPC failure
Wenzhe Zhou has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16456
Change subject: IMPALA-9227: Add coverage for query retries caused by RPC failure
......................................................................
IMPALA-9227: Add coverage for query retries caused by RPC failure
Added two new unit tests for query retries triggered by RPC failures.
The RPC failures are simulated by using debug_action to inject RPC
fault.
Testing:
- Passed test_query_retries.py, including the new test cases.
Change-Id: I6c800a764b22c72d5c408e14fd1bdea5336d7d82
---
M tests/custom_cluster/test_query_retries.py
1 file changed, 104 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/56/16456/1
--
To view, visit http://gerrit.cloudera.org:8080/16456
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6c800a764b22c72d5c408e14fd1bdea5336d7d82
Gerrit-Change-Number: 16456
Gerrit-PatchSet: 1
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-9227: Add coverage for query retries caused by RPC failure
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16456 )
Change subject: IMPALA-9227: Add coverage for query retries caused by RPC failure
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/7182/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/16456
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c800a764b22c72d5c408e14fd1bdea5336d7d82
Gerrit-Change-Number: 16456
Gerrit-PatchSet: 1
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Sep 2020 22:13:18 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9227: Add coverage for query retries caused by RPC failure
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/16456 )
Change subject: IMPALA-9227: Add coverage for query retries caused by RPC failure
......................................................................
IMPALA-9227: Add coverage for query retries caused by RPC failure
Added two new unit tests for query retries triggered by RPC failures.
The RPC failures are simulated by using debug_action to inject RPC
fault.
Testing:
- Passed test_query_retries.py, including the new test cases.
Change-Id: I6c800a764b22c72d5c408e14fd1bdea5336d7d82
---
M tests/custom_cluster/test_query_retries.py
1 file changed, 127 insertions(+), 23 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/56/16456/2
--
To view, visit http://gerrit.cloudera.org:8080/16456
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6c800a764b22c72d5c408e14fd1bdea5336d7d82
Gerrit-Change-Number: 16456
Gerrit-PatchSet: 2
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-9227: Add coverage for query retries caused by RPC failure
Posted by "Sahil Takiar (Code Review)" <ge...@cloudera.org>.
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16456 )
Change subject: IMPALA-9227: Add coverage for query retries caused by RPC failure
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/16456/2/tests/custom_cluster/test_query_retries.py
File tests/custom_cluster/test_query_retries.py:
http://gerrit.cloudera.org:8080/#/c/16456/2/tests/custom_cluster/test_query_retries.py@41
PS2, Line 41: def _get_rpc_fail_action(port, rpc):
It would be nice to have a test for the TransmitData RPC as well. I think currently all these tests run for ExecQueryFInstances only.
http://gerrit.cloudera.org:8080/#/c/16456/2/tests/custom_cluster/test_query_retries.py@285
PS2, Line 285: def test_retry_exec_query_rpc_failure(self):
I think only either 'test_retry_exec_query_rpc_failure' or 'test_retries_exec_query_rpc_failure' is necessary. I would prefer to keep 'test_retries_exec_query_rpc_failure' since it is more complex (tests multiple queries running concurrently).
--
To view, visit http://gerrit.cloudera.org:8080/16456
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c800a764b22c72d5c408e14fd1bdea5336d7d82
Gerrit-Change-Number: 16456
Gerrit-PatchSet: 2
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Mon, 21 Sep 2020 18:49:22 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9227: Add coverage for query retries caused by RPC failure
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16456 )
Change subject: IMPALA-9227: Add coverage for query retries caused by RPC failure
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/7204/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/16456
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c800a764b22c72d5c408e14fd1bdea5336d7d82
Gerrit-Change-Number: 16456
Gerrit-PatchSet: 2
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Fri, 18 Sep 2020 22:24:35 +0000
Gerrit-HasComments: No