You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by astroshim <gi...@git.apache.org> on 2017/09/08 10:20:47 UTC
[GitHub] zeppelin pull request #2576: [hotfix] JDBC connection does not release when ...
GitHub user astroshim opened a pull request:
https://github.com/apache/zeppelin/pull/2576
[hotfix] JDBC connection does not release when got exception.
### What is this PR for?
This PR fixes JDBC connection release problem.
for example when i run not executable command like following.
new JDBC connection is made like following.
```
$ netstat -an |grep EST |grep 3306 |wc -l
1
$ netstat -an |grep EST |grep 3306 |wc -l
2
$ netstat -an |grep EST |grep 3306 |wc -l
3
```
### What type of PR is it?
Bug Fix
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/astroshim/zeppelin fix/jdbcConnectionRelease
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2576.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2576
----
commit 88d3edb980e508e72d4cdde8e75c1005efcadda8
Author: Shim <yo...@gmail.com>
Date: 2017-09-08T09:55:24Z
fix jdbc connection relase issue.
commit 3ae59e9f02844445d011f682393bf359cb0a6f89
Author: Shim <yo...@gmail.com>
Date: 2017-09-08T10:20:25Z
fixed exception codes
----
---
[GitHub] zeppelin issue #2576: [hotfix] JDBC connection does not release when got exc...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/2576
If there is no new comment, I will merge it.
---
[GitHub] zeppelin pull request #2576: [hotfix] JDBC connection does not release when ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2576
---
[GitHub] zeppelin issue #2576: [hotfix] JDBC connection does not release when got exc...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2576
Tested jdbc interpreter test manually and CI failure looks irrelevant.
LGTM
---
[GitHub] zeppelin issue #2576: [hotfix] JDBC connection does not release when got exc...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/2576
@felixcheung
Thank you :)
---
[GitHub] zeppelin issue #2576: [hotfix] JDBC connection does not release when got exc...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/2576
Tested :)
Thank you for good fix.
---
[GitHub] zeppelin issue #2576: [hotfix] JDBC connection does not release when got exc...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/2576
This is a hot-fix change.
Therefore, they merge quickly.
---
[GitHub] zeppelin issue #2576: [hotfix] JDBC connection does not release when got exc...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/2576
I will merge to master
---
[GitHub] zeppelin issue #2576: [hotfix] JDBC connection does not release when got exc...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2576
Ok I think it's fine then
---