You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Nabarun Nag <nn...@apache.org> on 2018/03/21 16:51:43 UTC
[DISCUSS] gradle checks for test categories.
Hi,
As we have now categorized our tests to categories like LuceneTests,
WanTests, OQLQueriesTests, should we modify our gradle script to fail the
build if a new test class was added without a test category. This will
prevent test classes to be added without a fine level test category by
mistake.
Regards
Nabarun
Re: [DISCUSS] gradle checks for test categories.
Posted by Anthony Baker <ab...@pivotal.io>.
We could always have a backstop job that executes uncategorized tests…?
Anthony
> On Mar 21, 2018, at 10:29 AM, Nabarun Nag <nn...@apache.org> wrote:
>
> Yes, Jens. The new module level categorization like LuceneTests, WanTests.
> I am worried that a test may be checked in but it is never executed as a
> part of module category test pipelines because we missed to add the module
> category to the test.
>
> Regards
> Naba
>
> On Wed, Mar 21, 2018 at 10:14 AM Jens Deppe <jd...@pivotal.io> wrote:
>
>> The build already fails if a test is added without @Category. Do you mean
>> it should fail if the test also does not have one of these newer
>> categories?
>>
>> --Jens
>>
>> On Wed, Mar 21, 2018 at 9:51 AM, Nabarun Nag <nn...@apache.org> wrote:
>>
>>> Hi,
>>>
>>> As we have now categorized our tests to categories like LuceneTests,
>>> WanTests, OQLQueriesTests, should we modify our gradle script to fail the
>>> build if a new test class was added without a test category. This will
>>> prevent test classes to be added without a fine level test category by
>>> mistake.
>>>
>>> Regards
>>> Nabarun
>>>
>>
Re: [DISCUSS] gradle checks for test categories.
Posted by Nabarun Nag <nn...@apache.org>.
Yes, Jens. The new module level categorization like LuceneTests, WanTests.
I am worried that a test may be checked in but it is never executed as a
part of module category test pipelines because we missed to add the module
category to the test.
Regards
Naba
On Wed, Mar 21, 2018 at 10:14 AM Jens Deppe <jd...@pivotal.io> wrote:
> The build already fails if a test is added without @Category. Do you mean
> it should fail if the test also does not have one of these newer
> categories?
>
> --Jens
>
> On Wed, Mar 21, 2018 at 9:51 AM, Nabarun Nag <nn...@apache.org> wrote:
>
> > Hi,
> >
> > As we have now categorized our tests to categories like LuceneTests,
> > WanTests, OQLQueriesTests, should we modify our gradle script to fail the
> > build if a new test class was added without a test category. This will
> > prevent test classes to be added without a fine level test category by
> > mistake.
> >
> > Regards
> > Nabarun
> >
>
Re: [DISCUSS] gradle checks for test categories.
Posted by Jens Deppe <jd...@pivotal.io>.
The build already fails if a test is added without @Category. Do you mean
it should fail if the test also does not have one of these newer categories?
--Jens
On Wed, Mar 21, 2018 at 9:51 AM, Nabarun Nag <nn...@apache.org> wrote:
> Hi,
>
> As we have now categorized our tests to categories like LuceneTests,
> WanTests, OQLQueriesTests, should we modify our gradle script to fail the
> build if a new test class was added without a test category. This will
> prevent test classes to be added without a fine level test category by
> mistake.
>
> Regards
> Nabarun
>