You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "dpgaspar (via GitHub)" <gi...@apache.org> on 2023/03/03 11:27:18 UTC

[GitHub] [airflow] dpgaspar commented on a diff in pull request #29766: Upgrade FAB to 4.3.0

dpgaspar commented on code in PR #29766:
URL: https://github.com/apache/airflow/pull/29766#discussion_r1124332217


##########
airflow/www/extensions/init_appbuilder.py:
##########
@@ -172,10 +180,13 @@ def init_app(self, app, session):
         app.config.setdefault("APP_ICON", "")
         app.config.setdefault("LANGUAGES", {"en": {"flag": "gb", "name": "English"}})
         app.config.setdefault("ADDON_MANAGERS", [])
+        app.config.setdefault("RATELIMIT_ENABLED", True)

Review Comment:
   If I'm not mistaken, `RATELIMIT_ENABLED` will broadly enable rate limit since it can be added on `ModelRestApi` classes and `AUTH_RATE_LIMITED` will need `RATELIMIT_ENABLED` and add it to the auth views



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org