[GitHub] [geode] Bill commented on a change in pull request #7315: GEODE-9991: Configure SSLParameters directly.

[GitBox <gi...@apache.org>]

Bill commented on a change in pull request #7315:
URL: https://github.com/apache/geode/pull/7315#discussion_r793912047



##########
File path: geode-core/src/main/java/org/apache/geode/internal/net/SocketCreator.java
##########
@@ -362,38 +362,36 @@ public SSLEngine createSSLEngine(String hostName, int port, boolean clientSocket
   }
 
   @VisibleForTesting
-  void configureSSLEngine(SSLEngine engine, String hostName, int port, boolean clientSocket) {
-    SSLParameters parameters = engine.getSSLParameters();
-    boolean updateEngineWithParameters = false;
+  void configureSSLEngine(final SSLEngine engine, final String hostName, final int port,
+      final boolean clientSocket) {
+    engine.setUseClientMode(clientSocket);
+    final SSLParameters parameters = engine.getSSLParameters();
+    configureSSLParameters(parameters, hostName, port, clientSocket);
+    engine.setSSLParameters(parameters);

Review comment:
       I've reviewed the [PR for GEODE-8419](https://github.com/apache/geode/pull/5465) and it looks like the idea in both this method and in `configureClientSSLSocket()` was to set parameters at most once, and to avoid setting them at all if they didn't need to be modified.
   
   I wondered if setting them more aggressively e.g. unconditionally, had some untoward effect but I don't see that sort of issue when inspecting the code. 
   
   If setting everything via `SSLParameters` instead of a combination of `SSLParameters` and direct setter calls on the engine will work then it'll be a nice improvement. Our testing should answer that question.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org