You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/07/08 15:28:30 UTC

[GitHub] [bookkeeper] eolivelli commented on a diff in pull request #3393: Bugfix for zooKeeper client

eolivelli commented on code in PR #3393:
URL: https://github.com/apache/bookkeeper/pull/3393#discussion_r916925385


##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/zookeeper/ZooKeeperClient.java:
##########
@@ -317,6 +317,7 @@ protected ZooKeeperClient(String connectString,
 
     @Override
     public void close() throws InterruptedException {
+        logger.info("zooKeeper client start to close...");

Review Comment:
   no need to log this at "info" level



##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/zookeeper/ZooKeeperClient.java:
##########
@@ -351,6 +352,7 @@ public void process(WatchedEvent event) {
     private void onExpired() {
         if (closed.get()) {
             // we don't schedule any tries if the client is closed.
+            logger.info("we don't schedule any tries if the client is closed");

Review Comment:
   no need to log this at "info" level



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org