You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Jayush Luniya <jl...@hortonworks.com> on 2016/04/04 23:51:58 UTC

Review Request 45708: AMBARI-15699: Remove HDP specific hardcodings from common-services config properties

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45708/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez, Juanjo  Marron, and Sumit Mohanty.


Bugs: AMBARI-15699
    https://issues.apache.org/jira/browse/AMBARI-15699


Repository: ambari


Description
-------

Remove HDP specific hardcodings from common-services config properties


Diffs
-----

  ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/configuration/accumulo-env.xml 325886f 
  ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/configuration/accumulo-site.xml c2e0200 
  ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/ranger-knox-plugin-properties.xml eef1daf 
  ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/configuration/oozie-env.xml 6b3bb6c 
  ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.3/configuration/oozie-env.xml 3cda54a 
  ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/ranger-kms-policymgr-ssl.xml f6b4cbc 
  ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml ee0c48f 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/configuration/oozie-env.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/OOZIE/configuration/oozie-env.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/ZEPPELIN/configuration/zeppelin-env.xml PRE-CREATION 

Diff: https://reviews.apache.org/r/45708/diff/


Testing
-------


Thanks,

Jayush Luniya


Re: Review Request 45708: AMBARI-15699: Remove HDP specific hardcodings from common-services config properties

Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45708/#review126975
-----------------------------------------------------------


Ship it!




Ship It!

- Sumit Mohanty


On April 4, 2016, 10:11 p.m., Jayush Luniya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45708/
> -----------------------------------------------------------
> 
> (Updated April 4, 2016, 10:11 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Juanjo  Marron, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-15699
>     https://issues.apache.org/jira/browse/AMBARI-15699
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Remove HDP specific hardcodings from common-services config properties
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/configuration/accumulo-env.xml 325886f 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/configuration/accumulo-site.xml c2e0200 
>   ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/ranger-knox-plugin-properties.xml eef1daf 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/configuration/oozie-env.xml 6b3bb6c 
>   ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.3/configuration/oozie-env.xml 3cda54a 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/ranger-kms-policymgr-ssl.xml f6b4cbc 
>   ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml ee0c48f 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/configuration/oozie-env.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/OOZIE/configuration/oozie-env.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/ZEPPELIN/configuration/zeppelin-env.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45708/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test -DskipSurefireTests
> 
> ----------------------------------------------------------------------
> Ran 253 tests in 6.647s
> 
> OK
> ----------------------------------------------------------------------
> Total run:933
> Total errors:0
> Total failures:0
> OK
> INFO: AMBARI_SERVER_LIB is not set, using default /usr/lib/ambari-server
> INFO: Return code from stack upgrade command, retcode = 0
> StackAdvisor implementation for stack HDP1, version 2.0.6 was not found
> Returning DefaultStackAdvisor implementation
> StackAdvisor implementation for stack XYZ, version 1.0.0 was loaded
> StackAdvisor implementation for stack XYZ, version 1.0.1 was loaded
> Returning XYZ101StackAdvisor implementation
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 54.075s
> [INFO] Finished at: Mon Apr 04 15:11:13 PDT 2016
> [INFO] Final Memory: 62M/1125M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Jayush Luniya
> 
>


Re: Review Request 45708: AMBARI-15699: Remove HDP specific hardcodings from common-services config properties

Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45708/
-----------------------------------------------------------

(Updated April 4, 2016, 10:11 p.m.)


Review request for Ambari, Alejandro Fernandez, Juanjo  Marron, and Sumit Mohanty.


Bugs: AMBARI-15699
    https://issues.apache.org/jira/browse/AMBARI-15699


Repository: ambari


Description
-------

Remove HDP specific hardcodings from common-services config properties


Diffs
-----

  ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/configuration/accumulo-env.xml 325886f 
  ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/configuration/accumulo-site.xml c2e0200 
  ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/ranger-knox-plugin-properties.xml eef1daf 
  ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/configuration/oozie-env.xml 6b3bb6c 
  ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.3/configuration/oozie-env.xml 3cda54a 
  ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/ranger-kms-policymgr-ssl.xml f6b4cbc 
  ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml ee0c48f 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/configuration/oozie-env.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/OOZIE/configuration/oozie-env.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/ZEPPELIN/configuration/zeppelin-env.xml PRE-CREATION 

Diff: https://reviews.apache.org/r/45708/diff/


Testing (updated)
-------

mvn clean test -DskipSurefireTests

----------------------------------------------------------------------
Ran 253 tests in 6.647s

OK
----------------------------------------------------------------------
Total run:933
Total errors:0
Total failures:0
OK
INFO: AMBARI_SERVER_LIB is not set, using default /usr/lib/ambari-server
INFO: Return code from stack upgrade command, retcode = 0
StackAdvisor implementation for stack HDP1, version 2.0.6 was not found
Returning DefaultStackAdvisor implementation
StackAdvisor implementation for stack XYZ, version 1.0.0 was loaded
StackAdvisor implementation for stack XYZ, version 1.0.1 was loaded
Returning XYZ101StackAdvisor implementation
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 54.075s
[INFO] Finished at: Mon Apr 04 15:11:13 PDT 2016
[INFO] Final Memory: 62M/1125M
[INFO] ------------------------------------------------------------------------


Thanks,

Jayush Luniya