You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ode.apache.org by "Denis Weerasiri (JIRA)" <ji...@apache.org> on 2012/06/05 13:33:23 UTC
[jira] [Created] (ODE-967) Improvements to the the map of
messageExchanges maintained at in-memory representation of process instance
DAO
Denis Weerasiri created ODE-967:
-----------------------------------
Summary: Improvements to the the map of messageExchanges maintained at in-memory representation of process instance DAO
Key: ODE-967
URL: https://issues.apache.org/jira/browse/ODE-967
Project: ODE
Issue Type: Improvement
Components: BPEL Runtime
Affects Versions: 1.3.5
Environment: https://svn.apache.org/repos/asf/ode/trunk
Reporter: Denis Weerasiri
I'm proposing this code level improvement to in-memory DAO implementation in bpel-runtime.
In the in-memory representation of process instance DAO (org.apache.ode.bpel.memdao.ProcessInstanceDaoImpl), we see it maintains an unused map of messageExchanges.
eg - private Map<String, byte[]> _messageExchanges = new HashMap<String, byte[]>();
And the runtime representation of the message exchanges is quite weird as it's a byte array. But looking at the other DAO implementation, I think correct way to maintain a message exchange is to maintain a collection of org.apache.ode.bpel.dao.MessageExchangeDAO.
Here I've attached a patch which describes the code-level improvement.
Regards,
Denis Weerasiri
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ODE-967) Improvements to the the map of
messageExchanges maintained at in-memory representation of process instance
DAO
Posted by "Denis Weerasiri (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ODE-967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Denis Weerasiri updated ODE-967:
--------------------------------
Attachment: ODE-967-v1.patch
> Improvements to the the map of messageExchanges maintained at in-memory representation of process instance DAO
> --------------------------------------------------------------------------------------------------------------
>
> Key: ODE-967
> URL: https://issues.apache.org/jira/browse/ODE-967
> Project: ODE
> Issue Type: Improvement
> Components: BPEL Runtime
> Affects Versions: 1.4
> Environment: https://svn.apache.org/repos/asf/ode/trunk
> Reporter: Denis Weerasiri
> Labels: patch
> Attachments: ODE-967-v1.patch
>
>
> I'm proposing this code level improvement to in-memory DAO implementation in bpel-runtime.
> In the in-memory representation of process instance DAO (org.apache.ode.bpel.memdao.ProcessInstanceDaoImpl), we see it maintains an unused map of messageExchanges.
> eg - private Map<String, byte[]> _messageExchanges = new HashMap<String, byte[]>();
> And the runtime representation of the message exchanges is quite weird as it's a byte array. But looking at the other DAO implementation, I think correct way to maintain a message exchange is to maintain a collection of org.apache.ode.bpel.dao.MessageExchangeDAO.
> Here I've attached a patch which describes the code-level improvement.
> Regards,
> Denis Weerasiri
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ODE-967) Improvements to the the map of
messageExchanges maintained at in-memory representation of process instance
DAO
Posted by "Tammo van Lessen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ODE-967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13289356#comment-13289356 ]
Tammo van Lessen commented on ODE-967:
--------------------------------------
Depending on how often getMessageExchangeIds is called, it would be better to use a Map instead of a Collection in order to avoid the additional effort of iterating over all MEX daos for each method invocation.
> Improvements to the the map of messageExchanges maintained at in-memory representation of process instance DAO
> --------------------------------------------------------------------------------------------------------------
>
> Key: ODE-967
> URL: https://issues.apache.org/jira/browse/ODE-967
> Project: ODE
> Issue Type: Improvement
> Components: BPEL Runtime
> Affects Versions: 1.4
> Environment: https://svn.apache.org/repos/asf/ode/trunk
> Reporter: Denis Weerasiri
> Labels: patch
> Attachments: ODE-967-v1.patch
>
>
> I'm proposing this code level improvement to in-memory DAO implementation in bpel-runtime.
> In the in-memory representation of process instance DAO (org.apache.ode.bpel.memdao.ProcessInstanceDaoImpl), we see it maintains an unused map of messageExchanges.
> eg - private Map<String, byte[]> _messageExchanges = new HashMap<String, byte[]>();
> And the runtime representation of the message exchanges is quite weird as it's a byte array. But looking at the other DAO implementation, I think correct way to maintain a message exchange is to maintain a collection of org.apache.ode.bpel.dao.MessageExchangeDAO.
> Here I've attached a patch which describes the code-level improvement.
> Regards,
> Denis Weerasiri
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ODE-967) Improvements to the the map of
messageExchanges maintained at in-memory representation of process instance
DAO
Posted by "Denis Weerasiri (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ODE-967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Denis Weerasiri updated ODE-967:
--------------------------------
Affects Version/s: (was: 1.3.5)
1.4
> Improvements to the the map of messageExchanges maintained at in-memory representation of process instance DAO
> --------------------------------------------------------------------------------------------------------------
>
> Key: ODE-967
> URL: https://issues.apache.org/jira/browse/ODE-967
> Project: ODE
> Issue Type: Improvement
> Components: BPEL Runtime
> Affects Versions: 1.4
> Environment: https://svn.apache.org/repos/asf/ode/trunk
> Reporter: Denis Weerasiri
> Labels: patch
> Attachments: ODE-967-v1.patch
>
>
> I'm proposing this code level improvement to in-memory DAO implementation in bpel-runtime.
> In the in-memory representation of process instance DAO (org.apache.ode.bpel.memdao.ProcessInstanceDaoImpl), we see it maintains an unused map of messageExchanges.
> eg - private Map<String, byte[]> _messageExchanges = new HashMap<String, byte[]>();
> And the runtime representation of the message exchanges is quite weird as it's a byte array. But looking at the other DAO implementation, I think correct way to maintain a message exchange is to maintain a collection of org.apache.ode.bpel.dao.MessageExchangeDAO.
> Here I've attached a patch which describes the code-level improvement.
> Regards,
> Denis Weerasiri
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira