[jira] [Reopened] (HDFS-9353) Code and comment mismatch in JavaKeyStoreProvider

["Andras Bokor (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HDFS-9353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andras Bokor reopened HDFS-9353:
--------------------------------

[~templedf]

Thanks for taking a look on it.
First of all a note:
I checked it again. This comment is no longer in JavaKeyStorePrivider class. The related method was replaced into ProviderUtils with HADOOP-13157.

Back to the base problem:
I checked the code and it seems pretty straightforward. If you think it is misleading I would remove it. I do not feel we should explain this with in-line comments. Or we can add more explanation in the javadoc comment instead of inline.

What do you think?

> Code and comment mismatch in  JavaKeyStoreProvider 
> ---------------------------------------------------
>
>                 Key: HDFS-9353
>                 URL: https://issues.apache.org/jira/browse/HDFS-9353
>             Project: Hadoop HDFS
>          Issue Type: Task
>            Reporter: nijel
>            Assignee: Andras Bokor
>            Priority: Trivial
>
> In
> org.apache.hadoop.crypto.key.JavaKeyStoreProvider.JavaKeyStoreProvider(URI uri, Configuration conf) throws IOException
> The comment mentioned is
> {code}
> // Get the password file from the conf, if not present from the user's
> // environment var
> {code}
> But the code takes the value form ENV first
> I think this make sense since the user can pass the ENV for a particular run.
> My suggestion is to change the comment



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org