[GitHub] [superset] stephenLYZ edited a comment on pull request #17792: feat: color consistency

[GitBox <gi...@apache.org>]

stephenLYZ edited a comment on pull request #17792:
URL: https://github.com/apache/superset/pull/17792#issuecomment-1033896182


   > I have found some issue when testing:
   > 
   > 1, in the dashboard with label_color, if i edit color theme in meta data, the charts with label_color wont be able to change the color theme, but the charts without label_color can, with this edit, the color is not consistent for the dashboard
   > 
   >  Screen.Recording.2022-01-21.at.12.52.32.AM.mov 
   > 2, When user open a label_color chart in dashboard, and then try to save the chart, the label_color will be gone after the chart is saved.
   > 
   >  Screen.Recording.2022-01-21.at.12.36.14.AM.mov 
   > 3, Under specific condition of color#, the pie chart will show same color for connected section, this issue is filed before and still exist #17443
   
   1 - fixed.
   2 & 3 - Currently the master has the same problem, I will open another PR to solve.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org