You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "gavinchou (via GitHub)" <gi...@apache.org> on 2025/12/22 10:37:48 UTC

[PR] [chore](FE) Fix wrong springboot encoding properties [doris]

gavinchou opened a new pull request, #59264:
URL: https://github.com/apache/doris/pull/59264

   Spring Boot 2.x or 3.x change properties of "spring.http.encoding" to "server.servlet.encoding"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [chore](FE) Fix wrong springboot encoding properties [doris]

Posted by "gavinchou (via GitHub)" <gi...@apache.org>.
gavinchou commented on PR #59264:
URL: https://github.com/apache/doris/pull/59264#issuecomment-3681502050

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [chore](FE) Fix wrong springboot encoding properties [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59264:
URL: https://github.com/apache/doris/pull/59264#issuecomment-3682550896

   # FE Regression Coverage Report
   Increment line coverage `  100.00% (3/3)` :tada:
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/59264_d0bf414f8e11079fb5661ad99c814ce736bba796_merge_fe/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/59264_d0bf414f8e11079fb5661ad99c814ce736bba796_merge_fe/report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [chore](FE) Fix wrong springboot encoding properties [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59264:
URL: https://github.com/apache/doris/pull/59264#issuecomment-3681944173

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 27.85 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit d0bf414f8e11079fb5661ad99c814ce736bba796, data reload: false
   
   query1	0.05	0.04	0.05
   query2	0.10	0.05	0.05
   query3	0.25	0.09	0.08
   query4	1.60	0.11	0.12
   query5	0.27	0.26	0.26
   query6	1.17	0.65	0.63
   query7	0.03	0.02	0.02
   query8	0.05	0.04	0.05
   query9	0.57	0.50	0.51
   query10	0.56	0.57	0.55
   query11	0.16	0.10	0.11
   query12	0.15	0.12	0.12
   query13	0.61	0.60	0.60
   query14	1.00	0.97	0.99
   query15	0.81	0.80	0.80
   query16	0.40	0.38	0.40
   query17	1.01	1.06	1.00
   query18	0.23	0.22	0.23
   query19	1.84	1.77	1.76
   query20	0.02	0.01	0.02
   query21	15.44	0.31	0.14
   query22	4.57	0.05	0.05
   query23	16.07	0.28	0.10
   query24	1.43	1.08	0.87
   query25	0.09	0.11	0.06
   query26	0.14	0.12	0.13
   query27	0.06	0.06	0.06
   query28	5.12	1.23	1.01
   query29	12.62	4.00	3.27
   query30	0.29	0.14	0.12
   query31	2.83	0.61	0.40
   query32	3.24	0.55	0.47
   query33	2.95	3.08	3.01
   query34	17.03	5.16	4.55
   query35	4.56	4.54	4.62
   query36	0.65	0.49	0.49
   query37	0.11	0.07	0.07
   query38	0.06	0.04	0.04
   query39	0.04	0.02	0.02
   query40	0.17	0.15	0.13
   query41	0.09	0.04	0.03
   query42	0.05	0.03	0.03
   query43	0.04	0.03	0.03
   Total cold run time: 98.53 s
   Total hot run time: 27.85 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [chore](FE) Fix wrong springboot encoding properties [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #59264:
URL: https://github.com/apache/doris/pull/59264#issuecomment-3681541380

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [chore](FE) Fix incorrect character encoding in FE responses by updating encoding properties [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59264:
URL: https://github.com/apache/doris/pull/59264#issuecomment-3685284605

   # FE Regression Coverage Report
   Increment line coverage `  100.00% (3/3)` :tada:
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/59264_d0bf414f8e11079fb5661ad99c814ce736bba796_merge_fe/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/59264_d0bf414f8e11079fb5661ad99c814ce736bba796_merge_fe/report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [chore](FE) Fix wrong springboot encoding properties [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59264:
URL: https://github.com/apache/doris/pull/59264#issuecomment-3681927369

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 180506 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit d0bf414f8e11079fb5661ad99c814ce736bba796, data reload: false
   
   query5	5015	580	435	435
   query6	321	223	216	216
   query7	4222	469	281	281
   query8	313	249	246	246
   query9	8744	2568	2602	2568
   query10	550	379	329	329
   query11	15499	15532	15236	15236
   query12	180	125	115	115
   query13	1273	504	396	396
   query14	6344	3019	2737	2737
   query14_1	2638	2647	2644	2644
   query15	210	197	178	178
   query16	852	478	488	478
   query17	1144	706	597	597
   query18	2567	449	354	354
   query19	232	233	215	215
   query20	122	120	114	114
   query21	226	155	122	122
   query22	3900	4024	3997	3997
   query23	16536	16156	16239	16156
   query23_1	16187	16326	16283	16283
   query24	7369	1653	1253	1253
   query24_1	1274	1242	1232	1232
   query25	589	517	474	474
   query26	828	276	164	164
   query27	2722	487	314	314
   query28	4434	2179	2166	2166
   query29	838	581	495	495
   query30	325	251	222	222
   query31	803	709	653	653
   query32	80	76	70	70
   query33	558	345	297	297
   query34	876	915	538	538
   query35	784	795	721	721
   query36	883	894	815	815
   query37	119	145	76	76
   query38	2975	3012	2990	2990
   query39	740	751	724	724
   query39_1	703	716	689	689
   query40	219	141	121	121
   query41	64	61	63	61
   query42	106	104	107	104
   query43	442	443	385	385
   query44	1314	746	752	746
   query45	193	185	180	180
   query46	879	970	621	621
   query47	1723	1736	1635	1635
   query48	310	319	262	262
   query49	593	429	337	337
   query50	653	283	216	216
   query51	3747	3806	3764	3764
   query52	105	105	101	101
   query53	324	346	292	292
   query54	287	255	248	248
   query55	75	77	78	77
   query56	280	299	304	299
   query57	1136	1194	1118	1118
   query58	264	258	252	252
   query59	2392	2521	2509	2509
   query60	309	302	288	288
   query61	201	158	179	158
   query62	747	704	654	654
   query63	328	294	291	291
   query64	4301	1321	992	992
   query65	4059	3955	3987	3955
   query66	1378	432	311	311
   query67	15269	14941	14809	14809
   query68	8341	997	746	746
   query69	494	339	308	308
   query70	1096	976	969	969
   query71	355	303	281	281
   query72	6044	4882	4905	4882
   query73	662	559	310	310
   query74	8857	9040	8601	8601
   query75	3242	3163	2802	2802
   query76	3957	1167	750	750
   query77	589	396	303	303
   query78	9381	9607	8914	8914
   query79	1352	883	624	624
   query80	723	644	542	542
   query81	516	274	231	231
   query82	227	133	101	101
   query83	269	258	242	242
   query84	265	116	96	96
   query85	894	495	456	456
   query86	375	307	288	288
   query87	3154	3311	3164	3164
   query88	3207	2303	2333	2303
   query89	459	421	401	401
   query90	2160	157	149	149
   query91	170	160	150	150
   query92	85	73	64	64
   query93	1600	946	567	567
   query94	476	304	282	282
   query95	587	323	307	307
   query96	597	466	208	208
   query97	2252	2315	2235	2235
   query98	221	195	202	195
   query99	1315	1401	1242	1242
   Total cold run time: 259404 ms
   Total hot run time: 180506 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [chore](FE) Fix wrong springboot encoding properties [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59264:
URL: https://github.com/apache/doris/pull/59264#issuecomment-3681716109

   # FE UT Coverage Report
   Increment line coverage `  100.00% (3/3)` :tada:
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/59264_d0bf414f8e11079fb5661ad99c814ce736bba796/fe_increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/59264_d0bf414f8e11079fb5661ad99c814ce736bba796/fe_report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [chore](FE) Fix incorrect character encoding in FE responses by updating encoding properties [doris]

Posted by "gavinchou (via GitHub)" <gi...@apache.org>.
gavinchou merged PR #59264:
URL: https://github.com/apache/doris/pull/59264


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [chore](FE) Fix wrong springboot encoding properties [doris]

Posted by "gavinchou (via GitHub)" <gi...@apache.org>.
gavinchou commented on PR #59264:
URL: https://github.com/apache/doris/pull/59264#issuecomment-3681500782

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [chore](FE) Fix incorrect character encoding in FE responses by updating encoding properties [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59264:
URL: https://github.com/apache/doris/pull/59264#issuecomment-3685437042

   # FE Regression Coverage Report
   Increment line coverage `  100.00% (3/3)` :tada:
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/59264_d0bf414f8e11079fb5661ad99c814ce736bba796_merge_fe/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/59264_d0bf414f8e11079fb5661ad99c814ce736bba796_merge_fe/report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [chore](FE) Fix wrong springboot encoding properties [doris]

Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #59264:
URL: https://github.com/apache/doris/pull/59264#issuecomment-3681499737

   
   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
   
   Please clearly describe your PR:
   1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
   2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
   3. What features were added. Why was this function added?
   4. Which code was refactored and why was this part of the code refactored?
   5. Which functions were optimized and what is the difference before and after the optimization?
       


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [chore](FE) Fix wrong springboot encoding properties [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #59264:
URL: https://github.com/apache/doris/pull/59264#issuecomment-3681541178

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [chore](FE) Fix wrong springboot encoding properties [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59264:
URL: https://github.com/apache/doris/pull/59264#issuecomment-3681871286

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 35417 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit d0bf414f8e11079fb5661ad99c814ce736bba796, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17615	4211	4139	4139
   q2	2018	355	238	238
   q3	10181	1417	769	769
   q4	10207	838	328	328
   q5	7852	2190	1900	1900
   q6	236	167	134	134
   q7	1010	874	722	722
   q8	9362	1408	1291	1291
   q9	7132	5377	5316	5316
   q10	6873	2418	1991	1991
   q11	534	353	311	311
   q12	731	732	585	585
   q13	17785	3717	3043	3043
   q14	309	301	278	278
   q15	599	521	509	509
   q16	719	679	634	634
   q17	727	833	547	547
   q18	8112	7130	7121	7121
   q19	1096	965	621	621
   q20	387	358	252	252
   q21	4298	3973	3730	3730
   q22	1034	1004	958	958
   Total cold run time: 108817 ms
   Total hot run time: 35417 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	4131	4069	4098	4069
   q2	354	389	323	323
   q3	2138	2682	2299	2299
   q4	1373	1746	1333	1333
   q5	4277	4893	4560	4560
   q6	229	177	131	131
   q7	2081	1943	1811	1811
   q8	2708	2587	2495	2495
   q9	7671	7601	7497	7497
   q10	3102	3272	2846	2846
   q11	622	548	593	548
   q12	726	773	619	619
   q13	3533	3943	3321	3321
   q14	286	314	304	304
   q15	563	514	510	510
   q16	636	677	677	677
   q17	1278	1616	1488	1488
   q18	7714	7859	7438	7438
   q19	868	843	1019	843
   q20	2066	2072	1877	1877
   q21	4664	4240	4173	4173
   q22	1073	1060	994	994
   Total cold run time: 52093 ms
   Total hot run time: 50156 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org