[GitHub] elsloo closed pull request #2690: OnThrowable memory leak fix for Traffic Router Issue #2223

[GitBox <gi...@apache.org>]

elsloo closed pull request #2690: OnThrowable memory leak fix for Traffic Router Issue #2223
URL: https://github.com/apache/trafficcontrol/pull/2690
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/traffic_router/core/src/main/java/com/comcast/cdn/traffic_control/traffic_router/core/util/PeriodicResourceUpdater.java b/traffic_router/core/src/main/java/com/comcast/cdn/traffic_control/traffic_router/core/util/PeriodicResourceUpdater.java
index 5415bfbbf..efeafe99b 100644
--- a/traffic_router/core/src/main/java/com/comcast/cdn/traffic_control/traffic_router/core/util/PeriodicResourceUpdater.java
+++ b/traffic_router/core/src/main/java/com/comcast/cdn/traffic_control/traffic_router/core/util/PeriodicResourceUpdater.java
@@ -290,12 +290,6 @@ public Integer onCompleted(final Response response) throws IOException {
 		@Override
 		public void onThrowable(final Throwable t){
 			LOGGER.warn("Failed request " + request.getUrl() + ": " + t, t);
-			if (asyncHttpClient!=null) {
-				while (!asyncHttpClient.isClosed()) {
-					asyncHttpClient.close();
-				}
-			}
-			asyncHttpClient = newAsyncClient();
 		}
 	};
 
@@ -308,4 +302,4 @@ private Request getRequest(final String url) {
 			return null;
 		}
 	}
-}
\ No newline at end of file
+}


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services