[GitHub] [incubator-superset] ktmud edited a comment on pull request #11002: fix: revert #10455 to fix the Timer component

[GitBox <gi...@apache.org>]

ktmud edited a comment on pull request #11002:
URL: https://github.com/apache/incubator-superset/pull/11002#issuecomment-696999553


   > @tanmaylaud I'm not sure "functional components is recommended" is really a statement that can be broadly applied to all existing code.
   
   Just commenting on this one. Functional components [are absolutely the future of React](https://blog.bitsrc.io/will-react-classes-get-deprecated-because-of-hooks-bb62938ac1f5). I understand it requires significant amount of work to refactor some existing components, but I'd recommend everyone to start writing ALL new component as functional components and convert old components when possible (See the linked article for reasoning.)
   
   We should probably even add "new components should be written as functional components" to the contribution guideline.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org