[jira] [Comment Edited] (HBASE-14252) RegionServers fail to start when setting hbase.ipc.server.callqueue.scan.ratio=0.

["Matteo Bertozzi (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-14252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115442#comment-15115442 ] 

Matteo Bertozzi edited comment on HBASE-14252 at 1/25/16 4:01 PM:
------------------------------------------------------------------

patch looks good to me. 

maybe adding another test to cover the case, something like 
https://github.com/apache/hbase/blob/master/hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestSimpleRpcScheduler.java#L249


was (Author: mbertozzi):
patch looks good to me. 

> RegionServers fail to start when setting hbase.ipc.server.callqueue.scan.ratio=0.
> ---------------------------------------------------------------------------------
>
>                 Key: HBASE-14252
>                 URL: https://issues.apache.org/jira/browse/HBASE-14252
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>         Environment: hbase-0.98.6-cdh5.3.1
>            Reporter: Toshihiro Suzuki
>
> I set the following configuration in hbase-site.xml.
> {code}
> <property>
>   <name>hbase.ipc.server.callqueue.read.ratio</name>
>   <value>0.5</value>
> </property>
> <property>
>   <name>hbase.ipc.server.callqueue.scan.ratio</name>
>   <value>0</value>
> <property>
> {code}
> Then, the RegionServer failed to start and I saw the following log:
> {code}
> 2015-08-19 14:30:19,561 ERROR org.apache.hadoop.hbase.regionserver.HRegionServerCommandLine: Region server exiting
> java.lang.RuntimeException: Failed construction of Regionserver: class org.apache.hadoop.hbase.regionserver.HRegionServer
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.constructRegionServer(HRegionServer.java:2457)
>         at org.apache.hadoop.hbase.regionserver.HRegionServerCommandLine.start(HRegionServerCommandLine.java:61)
>         at org.apache.hadoop.hbase.regionserver.HRegionServerCommandLine.run(HRegionServerCommandLine.java:85)
>         at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
>         at org.apache.hadoop.hbase.util.ServerCommandLine.doMain(ServerCommandLine.java:126)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.main(HRegionServer.java:2472)
> Caused by: java.lang.reflect.InvocationTargetException
>         at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
>         at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:57)
>         at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
>         at java.lang.reflect.Constructor.newInstance(Constructor.java:526)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.constructRegionServer(HRegionServer.java:2455)
>         ... 5 more
> Caused by: java.lang.IllegalArgumentException: Queue size is <= 0, must be at least 1
>         at com.google.common.base.Preconditions.checkArgument(Preconditions.java:92)
>         at org.apache.hadoop.hbase.ipc.RpcExecutor.getBalancer(RpcExecutor.java:139)
>         at org.apache.hadoop.hbase.ipc.RWQueueRpcExecutor.<init>(RWQueueRpcExecutor.java:121)
>         at org.apache.hadoop.hbase.ipc.RWQueueRpcExecutor.<init>(RWQueueRpcExecutor.java:83)
>         at org.apache.hadoop.hbase.ipc.SimpleRpcScheduler.<init>(SimpleRpcScheduler.java:129)
>         at org.apache.hadoop.hbase.regionserver.SimpleRpcSchedulerFactory.create(SimpleRpcSchedulerFactory.java:36)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.<init>(HRegionServer.java:610)
>         ... 10 more
> {code}
> The doc of "hbase.ipc.server.callqueue.scan.ratio" says "A value of 0 or 1 indicate to use the same set of queues for gets and scans.".
> I think that there is a bug in validation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)