You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@avro.apache.org by GitBox <gi...@apache.org> on 2020/12/10 16:52:25 UTC

[GitHub] [avro] methodmissing opened a new pull request #1040: Reduce allocation in SchemaCompatibility.match_schemas when handling schema promotion for int and long writer types

methodmissing opened a new pull request #1040:
URL: https://github.com/apache/avro/pull/1040


   Reduces transient object allocation during decoding. Example 
   
   ```
   
   %TOTAL | %SELF | TOTAL | SELF | WAIT | CHILD | CALLS | NAME | ALLOCATIONS | LINE
   -- | -- | -- | -- | -- | -- | -- | -- | -- | --
     |   | 5000.00 | 5000.00 | 0.00 | 0.00 | 105000/105000 | <Class::Avro::IO::DatumReader>#match_schemas | - | 240
   -- | -- | -- | -- | -- | -- | -- | -- | -- | --
   5.55% | 5.55% | 5000.00 | 5000.00 | 0.00 | 0.00 | 105000 | <Module::Avro::SchemaCompatibility>#match_schemas | 5000 | 33
   Array4000 (160000 Bytes)/Users/lourens/src/github.com/Shopify/cdc/avro/lang/ruby/pkg/avro-1.11.0.pre1/lib/avro/schema_compatibility.rb:67Array1000 (40000 Bytes)/Users/lourens/src/github.com/Shopify/cdc/avro/lang/ruby/pkg/avro-1.11.0.pre1/lib/avro/schema_compatibility.rb:65 | Array | 4000 (160000 Bytes) | /Users/lourens/src/github.com/Shopify/cdc/avro/lang/ruby/pkg/avro-1.11.0.pre1/lib/avro/schema_compatibility.rb:67 | Array | 1000 (40000 Bytes) | /Users/lourens/src/github.com/Shopify/cdc/avro/lang/ruby/pkg/avro-1.11.0.pre1/lib/avro/schema_compatibility.rb:65
   Array | 4000 (160000 Bytes) | /Users/lourens/src/github.com/Shopify/cdc/avro/lang/ruby/pkg/avro-1.11.0.pre1/lib/avro/schema_compatibility.rb:67
   Array | 1000 (40000 Bytes) | /Users/lourens/src/github.com/Shopify/cdc/avro/lang/ruby/pkg/avro-1.11.0.pre1/lib/avro/schema_compatibility.rb:65
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] tjwp commented on pull request #1040: Reduce allocation in SchemaCompatibility.match_schemas when handling schema promotion for int and long writer types

Posted by GitBox <gi...@apache.org>.

tjwp commented on pull request #1040:
URL: https://github.com/apache/avro/pull/1040#issuecomment-743301656


   It looks like this is also addressed here: https://github.com/apache/avro/pull/1038


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] methodmissing commented on pull request #1040: Reduce allocation in SchemaCompatibility.match_schemas when handling schema promotion for int and long writer types

Posted by GitBox <gi...@apache.org>.

methodmissing commented on pull request #1040:
URL: https://github.com/apache/avro/pull/1040#issuecomment-743306956


   Thanks for correlating Tim, please defer to https://github.com/apache/avro/pull/1038 instead


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] methodmissing closed pull request #1040: Reduce allocation in SchemaCompatibility.match_schemas when handling schema promotion for int and long writer types

Posted by GitBox <gi...@apache.org>.

methodmissing closed pull request #1040:
URL: https://github.com/apache/avro/pull/1040


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org