You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2021/09/06 09:01:49 UTC

[GitHub] [submarine] KUAN-HSUN-LI commented on a change in pull request #736: SUBMARINE-1008. Submarine python code formatter and linter

KUAN-HSUN-LI commented on a change in pull request #736:
URL: https://github.com/apache/submarine/pull/736#discussion_r702731731



##########
File path: .github/workflows/python.yml
##########
@@ -40,9 +40,9 @@ jobs:
           pip install --no-cache-dir torch==1.5.0
           pip install --no-cache-dir ./submarine-sdk/pysubmarine/.
           pip install -r ./submarine-sdk/pysubmarine/github-actions/test-requirements.txt
-          pip install -r ./submarine-sdk/pysubmarine/github-actions/lint-requirements.txt
+          pip install -r ./dev-support/style-check/python/lint-requirements.txt
       - name: Check python sdk code style
-        run: ./submarine-sdk/pysubmarine/github-actions/lint.sh
+        run: ./dev-support/style-check/python/lint.sh

Review comment:
       OK. I will remove it and also remove the `auto-format.sh` in `./submarine-sdk/pysubmarine/github-actions/`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org