You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/07/15 05:21:57 UTC

[GitHub] [beam] lukecwik commented on a change in pull request #12260: [BEAM-10486] Update OffsetRestrictionTracker to honor failed claim attempt marking the claim as done when checkpointing.

lukecwik commented on a change in pull request #12260:
URL: https://github.com/apache/beam/pull/12260#discussion_r454798710



##########
File path: sdks/python/apache_beam/io/restriction_trackers.py
##########
@@ -92,7 +92,8 @@ def __init__(self, offset_range):
     self._checkpointed = False
 
   def check_done(self):
-    if self._last_claim_attempt < self._range.stop - 1:
+    if (self._range.start != self._range.stop and
+        self._last_claim_attempt < self._range.stop - 1):

Review comment:
       Good point




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org