You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/04/19 01:35:54 UTC
[GitHub] [flink] xuefuz commented on a change in pull request #8212:
[FLINK-11519][table] Add function related catalog APIs
xuefuz commented on a change in pull request #8212: [FLINK-11519][table] Add function related catalog APIs
URL: https://github.com/apache/flink/pull/8212#discussion_r276882033
##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/GenericInMemoryCatalog.java
##########
@@ -269,4 +273,81 @@ public boolean tableExists(ObjectPath tablePath) {
return tablePath != null && databaseExists(tablePath.getDatabaseName()) && tables.containsKey(tablePath);
}
+ // ------ functions ------
+
+ @Override
+ public void createFunction(ObjectPath functionPath, CatalogFunction function, boolean ignoreIfExists)
+ throws FunctionAlreadyExistException, DatabaseNotExistException {
+ checkArgument(functionPath != null);
Review comment:
Good thinking. However, I'd be consistent here with other similar checks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services