You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/08/29 05:45:19 UTC

[GitHub] [hbase] ddupg commented on a change in pull request #2126: HBASE-24759 Persisting configuration of default rsgroup

ddupg commented on a change in pull request #2126:
URL: https://github.com/apache/hbase/pull/2126#discussion_r479611730



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManagerImpl.java
##########
@@ -592,7 +594,13 @@ private synchronized void refresh(boolean forceOnline) throws IOException {
 
     // This is added to the last of the list so it overwrites the 'default' rsgroup loaded
     // from region group table or zk
-    groupList.add(new RSGroupInfo(RSGroupInfo.DEFAULT_GROUP, getDefaultServers(groupList)));

Review comment:
       `getDefaultServers` is still used in behind. This is just for version compatibility, not sure whether groupList has a default group or not after this patch.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org