[GitHub] [flink] JingGe opened a new pull request, #19699: [hotfix][table] avoid NPE and add more UTs. Remove System.out.println…

[GitBox <gi...@apache.org>]

JingGe opened a new pull request, #19699:
URL: https://github.com/apache/flink/pull/19699

   ## What is the purpose of the change
   
   improve the code quality while reading and understanding how code gen works.
   
   
   ## Brief change log
   
     -  move code length check into splitImpl(...) method to avoid NPE. 
     -  add more UTs to test argument check logics.
     - remove System.out.println() call.
   
   ## Verifying this change
   
   This change is already covered by existing tests, such as JavaCodeSplitterTest.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #19699: [hotfix][table] avoid NPE and add more UTs.

[GitBox <gi...@apache.org>]

flinkbot commented on PR #19699:
URL: https://github.com/apache/flink/pull/19699#issuecomment-1123761596

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c509401fc3da54c9b66026132d36a515a0e14776",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c509401fc3da54c9b66026132d36a515a0e14776",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c509401fc3da54c9b66026132d36a515a0e14776 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] gaoyunhaii closed pull request #19699: [hotfix][table] avoid NPE and add more UTs.

[GitBox <gi...@apache.org>]

gaoyunhaii closed pull request #19699: [hotfix][table] avoid NPE and add more UTs. 
URL: https://github.com/apache/flink/pull/19699


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org