[GitHub] [kafka] tombentley commented on a change in pull request #9433: KAFKA-10607: Consistent behaviour for response errorCounts()

[GitBox <gi...@apache.org>]

tombentley commented on a change in pull request #9433:
URL: https://github.com/apache/kafka/pull/9433#discussion_r520532036



##########
File path: clients/src/test/java/org/apache/kafka/common/requests/RequestResponseTest.java
##########
@@ -1921,7 +1929,7 @@ private CreateAclsResponse createCreateAclsResponse() {
         return new CreateAclsResponse(new CreateAclsResponseData().setResults(asList(
             new CreateAclsResponseData.AclCreationResult(),
             new CreateAclsResponseData.AclCreationResult()
-                .setErrorCode(Errors.INVALID_REQUEST.code())
+                .setErrorCode(Errors.NONE.code())

Review comment:
       I wanted to ensure that for error code fields in all RPCs we were including NONE in the count. I would have factored out a method taking the error code to use if any of the rest of the tests depended on the actual error code used, but they don't. We'd need to revisit this if [KIP-636](https://cwiki.apache.org/confluence/display/KAFKA/KIP-636%3A+Make+RPC+error+codes+and+messages+tagged+fields) were ever accepted (since it would interfere with coverage of the serialization test), but it seems harmless for the time being.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org