[GitHub] anirudh2290 opened a new pull request #10938: Add Apachev2 License for contrib

[GitBox <gi...@apache.org>]

anirudh2290 opened a new pull request #10938: Add Apachev2 License for contrib
URL: https://github.com/apache/incubator-mxnet/pull/10938
 
 
   ## Description ##
   We were asked this question on general@ on why so many files were excluded in rat-excludes. 
   This is an attempt to remove the contrib/ directory from rat-excludes.
   I have added apache v2 license headers for files which had these headers missing and from https://github.com/apache/incubator-mxnet/pull/5834 it seems like all these files were supposed to be Apache v2 Licenses @sbodenstein can you please confirm this? Also removed the contrib directory from rat-excludes. This will cause the  apache rat check to flag some files in contrib directory which are nvidia licensed or BSD licensed 
   which should be fine.
   
   @mbaijal @sbodenstein @hen 
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes)
   - [ ] Changes are complete (i.e. I finished coding on this PR)
   - [ ] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
   - Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
   - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
   - [ ] Code is well-documented: 
   - For user-facing API changes, API doc string has been updated. 
   - For new C++ functions in header files, their functionalities and arguments are documented. 
   - For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
   - Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
   - [ ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
   
   ### Changes ###
   - [ ] Feature1, tests, (and when applicable, API doc)
   - [ ] Feature2, tests, (and when applicable, API doc)
   
   ## Comments ##
   - If this change is a backward incompatible change, why must this change be made.
   - Interesting edge cases to note here
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services