You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by "vttranlina (via GitHub)" <gi...@apache.org> on 2024/12/03 09:43:45 UTC

Re: [PR] Improve S3 MinIO support with MinIOGenerationAwareBlobId [james-project]

vttranlina commented on code in PR #2542:
URL: https://github.com/apache/james-project/pull/2542#discussion_r1867357404


##########
server/container/guice/blob/deduplication-gc/src/main/java/org/apache/james/modules/blobstore/BlobDeduplicationGCModule.java:
##########
@@ -68,8 +69,15 @@ protected void configure() {
 
     @Singleton
     @Provides
-    public GenerationAwareBlobId.Factory generationAwareBlobIdFactory(Clock clock, PlainBlobId.Factory delegate, GenerationAwareBlobId.Configuration configuration) {
-        return new GenerationAwareBlobId.Factory(clock, delegate, configuration);
+    public BlobId.Factory generationAwareBlobIdFactory(Clock clock, PlainBlobId.Factory delegate, GenerationAwareBlobId.Configuration configuration) {
+            String property = System.getProperty("james.s3.minio.compatibility.mode");

Review Comment:
   I see in the ticket 
   ```
   Have an option in blobstore.properties to actually switch to that MinIO compatibility mode:
   ```
   Do you need it? I can adapt it @chibenwa 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org