You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/04/10 07:33:27 UTC

[GitHub] [pulsar] mattisonchao commented on pull request #15098: [fix][broker] patch #5809: Fix the ledgerID not found cause NPE.

mattisonchao commented on PR #15098:
URL: https://github.com/apache/pulsar/pull/15098#issuecomment-1094206797

   > > Overall LGTM, but i have a question: Could we check for an `OpReadEntry` earlier (to avoid creating useless objects) or throw an exception (to achieve fail fast) when creating it? Please let me know what you think, thanks~
   > 
   > yep, I have thought it, but it's not atomic, it need user make invalid outside. This way more secure.
   
   Got it. I was just wondering if there is a race condition here.
   I would also like to say that we can throw an exception when we get an empty location. But it doesn't look particularly different from your approach.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org